From: Robert Pluim <rpluim@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Aaron Zeng <zeng.aaron.l@gmail.com>, 43677@debbugs.gnu.org
Subject: bug#43677: 27.1; Calc holidays off-by-one error, incorrect business day calculation
Date: Wed, 30 Sep 2020 10:55:10 +0200 [thread overview]
Message-ID: <m28scr4pap.fsf@gmail.com> (raw)
In-Reply-To: <87sgb07zbi.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 30 Sep 2020 04:50:25 +0200")
>>>>> On Wed, 30 Sep 2020 04:50:25 +0200, Lars Ingebrigtsen <larsi@gnus.org> said:
Lars> Indeed -- applying the following patch (which numbers Monday as 0 and
Lars> Sunday as 6) makes the test case work correctly for me. But trying to
Lars> follow the code makes it unclear... er... what's going on, and there
Lars> aren't many comments in the Calc code to explain what they were
Lars> thinking.
Lars> I wondered whether this might be a US/non-US thing (with a difference in
Lars> what day starts the week), but I couldn't really find anything in calc
Lars> talking about that...
Lars> Does anybody have any insight here?
Sunday is the first day of the week in the US and in France (and
others, probably). Monday is the first *business* day of the week,
which I think is what's important here.
Robert
--
next prev parent reply other threads:[~2020-09-30 8:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 1:18 bug#43677: 27.1; Calc holidays off-by-one error, incorrect business day calculation Aaron Zeng
2020-09-30 2:50 ` Lars Ingebrigtsen
2020-09-30 8:55 ` Robert Pluim [this message]
2020-09-30 9:42 ` Mattias Engdegård
2020-09-30 13:40 ` Lars Ingebrigtsen
2020-09-30 15:52 ` Glenn Morris
2020-09-30 16:22 ` Lars Ingebrigtsen
2020-09-30 16:31 ` Andreas Schwab
2020-09-30 16:12 ` Mattias Engdegård
2020-09-30 16:23 ` Lars Ingebrigtsen
2020-10-01 10:19 ` Mattias Engdegård
2020-10-01 22:47 ` Aaron Zeng
2020-10-02 10:00 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m28scr4pap.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=43677@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=zeng.aaron.l@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).