From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Zeng Newsgroups: gmane.emacs.bugs Subject: bug#43677: 27.1; Calc holidays off-by-one error, incorrect business day calculation Date: Thu, 1 Oct 2020 18:47:58 -0400 Message-ID: References: <0FA74B6A-DD93-41D7-91C4-ED4EB881E2DD@acm.org> <87blhn757u.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40352"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 43677@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 02 00:49:29 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kO7OC-000ANj-Nu for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Oct 2020 00:49:28 +0200 Original-Received: from localhost ([::1]:42434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kO7OB-0008SP-0P for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 18:49:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kO7Nm-0008SA-Jb for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 18:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55380) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kO7Nm-0001z0-AU for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 18:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kO7Nm-0001jS-7R for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 18:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Zeng Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Oct 2020 22:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43677 X-GNU-PR-Package: emacs Original-Received: via spool by 43677-submit@debbugs.gnu.org id=B43677.16015925276638 (code B ref 43677); Thu, 01 Oct 2020 22:49:02 +0000 Original-Received: (at 43677) by debbugs.gnu.org; 1 Oct 2020 22:48:47 +0000 Original-Received: from localhost ([127.0.0.1]:38693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO7NX-0001iz-2i for submit@debbugs.gnu.org; Thu, 01 Oct 2020 18:48:47 -0400 Original-Received: from mail-ot1-f50.google.com ([209.85.210.50]:36261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO7NR-0001ii-F7 for 43677@debbugs.gnu.org; Thu, 01 Oct 2020 18:48:45 -0400 Original-Received: by mail-ot1-f50.google.com with SMTP id 60so407512otw.3 for <43677@debbugs.gnu.org>; Thu, 01 Oct 2020 15:48:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BftteIKvl594ie2ecERMQFTuQT2HrHBfHhrtnk+rpsE=; b=ttjd76Ev6FSyT5W8bZtWVT6wGv9l2d1MD1eVut18Rhlo3RO/jLC+aeXFHdsFpRY9KC lfwf8ag1rhurMviQMapKbQ5QJ2KBLYM+656jRTNgXY3NRw5pjAkJ2yk72OA6eDZZEeqi hhRX9t9eF0wx5O4QCQmzrxsNCWcDLO5dHkWQxHujjkl/Fp4R1Ygu9iHJ8p9xS19IqsqZ fYCGKx+MxnTPu4v35QUZrTq3ddFXq5ebU9Yl5NaPTeUoCkQJ5IUcAoOk6wawmAd14Svg ztjRJSNxMIsjQVQMcjytnpBiXv+vT8TQN/fbRmtIWLyhUc994a+3Mbv+1+d71hIrdqpZ nxKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BftteIKvl594ie2ecERMQFTuQT2HrHBfHhrtnk+rpsE=; b=D5mOtmWLSKbi38gpUoO2EYoJ2UMBvM83AwHZx1re/h3g4CRezV7XsZqnXWJedXIt7S unCGz3Y2Bl6YTL7ZURpyXxRitGUNbEdK5iYhyPBCF7/E1VFLc2TYjoTXq5qRK3RgVTow mI5uDCp9tB5gmZbJ+tG6Yb0DJFVeSLbyQsynCGk47l1WH6+OqERpLzGepQNFk5D5MO5L AxeF0QN+nH5a8vYAlJguHmLQg0D7denjoOkuBibXDRYv2mTDfdC5gym3fYuD3NteErxT 5nxVPPsb6tkH2/gYCC025682Y7DxIMhX2xfCxuSofCUDwpA7t6PPiutlUT2HBhMbIhdl KxbA== X-Gm-Message-State: AOAM533rTm60JakCA4hB5Wb8ZR5gghejIUiKDtDjA93AtEUOrSkTcDg7 dSJX7LjC7pqE/fBqM/GWRDBROm4xDKZPcG7JbUs= X-Google-Smtp-Source: ABdhPJwO+2u/dY55sgWTPiBVcXkgfvYhDqtqwSBzb7MWMEDOOnu7nZVoeXmTdTAslHLD8Er0dAN+Fwa4R5Vwiw399RE= X-Received: by 2002:a9d:8d2:: with SMTP id 76mr4031814otf.270.1601592515608; Thu, 01 Oct 2020 15:48:35 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189599 Archived-At: Mattias, that patch seems to work well for me (I tested this by just loading the lisp into an older version of emacs, since I don't have experience compiling emacs from source). I don't need business days for BC dates. Thanks all for the quick responses. On Thu, Oct 1, 2020 at 6:19 AM Mattias Engdeg=C3=A5rd wr= ote: > > Aaron, does this patch solve your problem? > > It turned out that the ability to select arbitrary holiday weekdays never= really worked correctly; the patch attempts to do something about that as = well. > > The business days code also doesn't work at all very well for BC dates, w= hich of course limits its applicability somewhat but perhaps not critically= so. Please tell me if that is something you need fixed. > > >