* bug#14346: 24.3; beginning-of-visual-line jumps to previous line in org-mode
@ 2013-05-04 9:08 E Sabof
2013-05-04 11:01 ` Eli Zaretskii
2019-09-30 15:59 ` Stefan Kangas
0 siblings, 2 replies; 9+ messages in thread
From: E Sabof @ 2013-05-04 9:08 UTC (permalink / raw)
To: 14346
[-- Attachment #1: Type: text/plain, Size: 316 bytes --]
In a buffer with org-mode and visual line-mode, paste this text:
text
[[TEXT]]
Put cursor on E
Press [left arrow].
Press [home] (or C-a, bound to org-beginning-of-line)
The cursor will go to the end of the previous line
The behavior is correct, if one invokes either of those functions through
M-x or M-:
Evgeni
[-- Attachment #2: Type: text/html, Size: 603 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#14346: 24.3; beginning-of-visual-line jumps to previous line in org-mode
2013-05-04 9:08 bug#14346: 24.3; beginning-of-visual-line jumps to previous line in org-mode E Sabof
@ 2013-05-04 11:01 ` Eli Zaretskii
2013-05-04 11:05 ` Eli Zaretskii
2019-09-30 15:59 ` Stefan Kangas
1 sibling, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2013-05-04 11:01 UTC (permalink / raw)
To: E Sabof; +Cc: 14346
> Date: Sat, 4 May 2013 10:08:46 +0100
> From: E Sabof <esabof@gmail.com>
>
> In a buffer with org-mode and visual line-mode, paste this text:
>
> text
> [[TEXT]]
>
> Put cursor on E
> Press [left arrow].
> Press [home] (or C-a, bound to org-beginning-of-line)
> The cursor will go to the end of the previous line
>
> The behavior is correct, if one invokes either of those functions through
> M-x or M-:
That's point adjustment feature in action: it moves point further in
the same direction if point winds up in invisible text. Customize
disable-point-adjustment to a non-nil value, if you don't want that to
happen.
Does anyone (Stefan? Glenn? anyone else?) see any reasons to try and
fix this, as opposed to deciding that this is a "feature"?
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#14346: 24.3; beginning-of-visual-line jumps to previous line in org-mode
2013-05-04 11:01 ` Eli Zaretskii
@ 2013-05-04 11:05 ` Eli Zaretskii
2013-05-04 11:17 ` E Sabof
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2013-05-04 11:05 UTC (permalink / raw)
To: esabof; +Cc: 14346
> Date: Sat, 04 May 2013 14:01:21 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 14346@debbugs.gnu.org
>
> Customize disable-point-adjustment to a non-nil value, if you don't
> want that to happen.
Sorry, I meant global-disable-point-adjustment
(disable-point-adjustment is reset to nil before each command, so it
won't do what I meant).
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#14346: 24.3; beginning-of-visual-line jumps to previous line in org-mode
2013-05-04 11:05 ` Eli Zaretskii
@ 2013-05-04 11:17 ` E Sabof
2013-05-04 12:16 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: E Sabof @ 2013-05-04 11:17 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 14346
[-- Attachment #1: Type: text/plain, Size: 628 bytes --]
On Sat, May 4, 2013 at 12:05 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > Date: Sat, 04 May 2013 14:01:21 +0300
> > From: Eli Zaretskii <eliz@gnu.org>
> > Cc: 14346@debbugs.gnu.org
> >
> > Customize disable-point-adjustment to a non-nil value, if you don't
> > want that to happen.
>
> Sorry, I meant global-disable-point-adjustment
> (disable-point-adjustment is reset to nil before each command, so it
> won't do what I meant).
>
I see what you mean. But it still looks like a bug - whether I follow the
above recipe, or press C-e C-a, the point will (should?) go to the same
position, but the behavior is different.
Evgeni
[-- Attachment #2: Type: text/html, Size: 1191 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#14346: 24.3; beginning-of-visual-line jumps to previous line in org-mode
2013-05-04 11:17 ` E Sabof
@ 2013-05-04 12:16 ` Eli Zaretskii
2013-05-04 13:27 ` E Sabof
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2013-05-04 12:16 UTC (permalink / raw)
To: E Sabof; +Cc: 14346
> Date: Sat, 4 May 2013 12:17:35 +0100
> From: E Sabof <esabof@gmail.com>
> Cc: 14346@debbugs.gnu.org
>
> I see what you mean. But it still looks like a bug - whether I follow the
> above recipe, or press C-e C-a, the point will (should?) go to the same
> position, but the behavior is different.
The behavior depends on the direction point was moving before ending
up in the invisible text. It's a heuristic, and as every heuristic,
it sometimes fails.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#14346: 24.3; beginning-of-visual-line jumps to previous line in org-mode
2013-05-04 12:16 ` Eli Zaretskii
@ 2013-05-04 13:27 ` E Sabof
2013-05-07 1:34 ` E Sabof
[not found] ` <CAEp6DyaDWtuw96Hm73BA-WOdiez8O7ud0stCQSycaLS5KXkZ0A@mail.gmail.com>
0 siblings, 2 replies; 9+ messages in thread
From: E Sabof @ 2013-05-04 13:27 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 14346
[-- Attachment #1: Type: text/plain, Size: 896 bytes --]
Wouldn't it be better if forward/backward-char kept the old behavior, and
the rest of the commands did something similar to this in the end:
(setq disable-point-adjustment
(preceding-or-following-character-visible-p))
I'm not entirely sure whether it would be better, but at the moment, I
can't think of a case where it wouldn't.
Evgeni
On Sat, May 4, 2013 at 1:16 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > Date: Sat, 4 May 2013 12:17:35 +0100
> > From: E Sabof <esabof@gmail.com>
> > Cc: 14346@debbugs.gnu.org
> >
> > I see what you mean. But it still looks like a bug - whether I follow the
> > above recipe, or press C-e C-a, the point will (should?) go to the same
> > position, but the behavior is different.
>
> The behavior depends on the direction point was moving before ending
> up in the invisible text. It's a heuristic, and as every heuristic,
> it sometimes fails.
>
[-- Attachment #2: Type: text/html, Size: 1485 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#14346: 24.3; beginning-of-visual-line jumps to previous line in org-mode
2013-05-04 13:27 ` E Sabof
@ 2013-05-07 1:34 ` E Sabof
[not found] ` <CAEp6DyaDWtuw96Hm73BA-WOdiez8O7ud0stCQSycaLS5KXkZ0A@mail.gmail.com>
1 sibling, 0 replies; 9+ messages in thread
From: E Sabof @ 2013-05-07 1:34 UTC (permalink / raw)
To: Eli Zaretskii, emacs-orgmode; +Cc: 14346
[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]
Even if the behavior doesn't change (soon), could the equivalent of the
following be implemented in org-mode? It's the only place where this has
been problematic for me.
(defadvice org-beginning-of-line (after smart-point-adjustment activate)
(setq disable-point-adjustment
(or (not (invisible-p (point)))
(not (invisible-p (max (point-min) (1- (point))))))))
(defadvice org-end-of-line (after smart-point-adjustment activate)
(setq disable-point-adjustment
(or (not (invisible-p (point)))
(not (invisible-p (max (point-min) (1- (point))))))))
Evgeni
On Sat, May 4, 2013 at 2:27 PM, E Sabof <esabof@gmail.com> wrote:
> Wouldn't it be better if forward/backward-char kept the old behavior, and
> the rest of the commands did something similar to this in the end:
>
> (setq disable-point-adjustment
> (preceding-or-following-character-visible-p))
>
> I'm not entirely sure whether it would be better, but at the moment, I
> can't think of a case where it wouldn't.
>
> Evgeni
>
>
> On Sat, May 4, 2013 at 1:16 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> > Date: Sat, 4 May 2013 12:17:35 +0100
>> > From: E Sabof <esabof@gmail.com>
>> > Cc: 14346@debbugs.gnu.org
>> >
>> > I see what you mean. But it still looks like a bug - whether I follow
>> the
>> > above recipe, or press C-e C-a, the point will (should?) go to the same
>> > position, but the behavior is different.
>>
>> The behavior depends on the direction point was moving before ending
>> up in the invisible text. It's a heuristic, and as every heuristic,
>> it sometimes fails.
>>
>
>
[-- Attachment #2: Type: text/html, Size: 2667 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#14346: [O] bug#14346: 24.3; beginning-of-visual-line jumps to previous line in org-mode
[not found] ` <CAEp6DyaDWtuw96Hm73BA-WOdiez8O7ud0stCQSycaLS5KXkZ0A@mail.gmail.com>
@ 2013-05-10 7:00 ` Carsten Dominik
0 siblings, 0 replies; 9+ messages in thread
From: Carsten Dominik @ 2013-05-10 7:00 UTC (permalink / raw)
To: E Sabof; +Cc: 14346, emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 1832 bytes --]
On 7.5.2013, at 03:34, E Sabof <esabof@gmail.com> wrote:
> Even if the behavior doesn't change (soon), could the equivalent of the following be implemented in org-mode? It's the only place where this has been problematic for me.
>
> (defadvice org-beginning-of-line (after smart-point-adjustment activate)
> (setq disable-point-adjustment
> (or (not (invisible-p (point)))
> (not (invisible-p (max (point-min) (1- (point))))))))
>
> (defadvice org-end-of-line (after smart-point-adjustment activate)
> (setq disable-point-adjustment
> (or (not (invisible-p (point)))
> (not (invisible-p (max (point-min) (1- (point))))))))
I have implemented these in Org master, so this will eventually mode into emacs as well.
- Carsten
>
> Evgeni
>
>
> On Sat, May 4, 2013 at 2:27 PM, E Sabof <esabof@gmail.com> wrote:
> Wouldn't it be better if forward/backward-char kept the old behavior, and the rest of the commands did something similar to this in the end:
>
> (setq disable-point-adjustment
> (preceding-or-following-character-visible-p))
>
> I'm not entirely sure whether it would be better, but at the moment, I can't think of a case where it wouldn't.
>
> Evgeni
>
>
> On Sat, May 4, 2013 at 1:16 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > Date: Sat, 4 May 2013 12:17:35 +0100
> > From: E Sabof <esabof@gmail.com>
> > Cc: 14346@debbugs.gnu.org
> >
> > I see what you mean. But it still looks like a bug - whether I follow the
> > above recipe, or press C-e C-a, the point will (should?) go to the same
> > position, but the behavior is different.
>
> The behavior depends on the direction point was moving before ending
> up in the invisible text. It's a heuristic, and as every heuristic,
> it sometimes fails.
>
>
[-- Attachment #2: Type: text/html, Size: 3378 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#14346: [O] bug#14346: 24.3; beginning-of-visual-line jumps to previous line in org-mode
2013-05-04 9:08 bug#14346: 24.3; beginning-of-visual-line jumps to previous line in org-mode E Sabof
2013-05-04 11:01 ` Eli Zaretskii
@ 2019-09-30 15:59 ` Stefan Kangas
1 sibling, 0 replies; 9+ messages in thread
From: Stefan Kangas @ 2019-09-30 15:59 UTC (permalink / raw)
To: Carsten Dominik; +Cc: E Sabof, 14346-done
Carsten Dominik <carsten.dominik@gmail.com> writes:
> I have implemented these in Org master, so this will eventually mode
> into emacs as well.
It seems like this was implemented at the time, and should be merged
to master by now. I'm therefore closing this bug report.
If there is still any issues here that I'm missing, please reopen the
bug report.
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-09-30 15:59 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-04 9:08 bug#14346: 24.3; beginning-of-visual-line jumps to previous line in org-mode E Sabof
2013-05-04 11:01 ` Eli Zaretskii
2013-05-04 11:05 ` Eli Zaretskii
2013-05-04 11:17 ` E Sabof
2013-05-04 12:16 ` Eli Zaretskii
2013-05-04 13:27 ` E Sabof
2013-05-07 1:34 ` E Sabof
[not found] ` <CAEp6DyaDWtuw96Hm73BA-WOdiez8O7ud0stCQSycaLS5KXkZ0A@mail.gmail.com>
2013-05-10 7:00 ` bug#14346: [O] " Carsten Dominik
2019-09-30 15:59 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).