From: Carlos Pita <carlosjosepita@gmail.com>
To: Juri Linkov <juri@linkov.net>, 32344@debbugs.gnu.org
Subject: bug#32344: Add option to keep colorization in comint, use it in python.el
Date: Mon, 21 Oct 2019 17:53:06 -0300 [thread overview]
Message-ID: <CAELgYhcRZXRY-9zZko2hQzrTv=EE5YoHXurTMEhWjHcJUxCPXg@mail.gmail.com> (raw)
In-Reply-To: <87h8kdwro4.fsf@gmail.com>
> But I wonder if you could just replace add-text-properties with
> add-face-text-property? It will keep your previous text properties
> and will just merge them with the comint-highlight-input face.
I'm not sure about this:
> If any text in the region already has a non-nil ‘face’ property, those
> face(s) are retained.
Is the default face represented as a nil face property? Will it be
overridden? In that case the mix could be ugly.
In general I'd prefer to keep both paths of execution as separate as
possible so as to avoid regressions.
next prev parent reply other threads:[~2019-10-21 20:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 0:14 bug#32344: 26.1; Option to avoid comint highlighting input Carlos Pita
2018-08-02 1:19 ` bug#32344: Carlos Pita
2018-09-12 17:04 ` bug#32344: Carlos Pita
2018-09-17 16:36 ` bug#32344: (no subject) Jörg Behrmann
2019-10-13 17:18 ` bug#32344: Carlos Pita
2019-10-13 18:36 ` bug#32344: Carlos Pita
2019-10-13 19:23 ` bug#32344: Carlos Pita
2019-10-13 19:24 ` bug#32344: Carlos Pita
2019-10-13 21:53 ` bug#32344: [PATCH] 26.3/27 Option to avoid comint override colorization provided by major modes Carlos Pita
2019-10-21 20:39 ` Carlos Pita
2020-08-10 12:51 ` Lars Ingebrigtsen
2020-08-19 11:11 ` Lars Ingebrigtsen
2019-10-20 15:57 ` bug#32344: Juri Linkov
2019-10-14 17:16 ` bug#32344: [PATCH] 26.3/27 Option to avoid comint override colorization provided by major modes Gaby Launay via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-21 20:53 ` Carlos Pita [this message]
2019-10-22 18:25 ` bug#32344: Add option to keep colorization in comint, use it in python.el Carlos Pita
2019-10-22 20:37 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAELgYhcRZXRY-9zZko2hQzrTv=EE5YoHXurTMEhWjHcJUxCPXg@mail.gmail.com' \
--to=carlosjosepita@gmail.com \
--cc=32344@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).