From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#32344: Add option to keep colorization in comint, use it in python.el Date: Mon, 21 Oct 2019 17:53:06 -0300 Message-ID: References: <87h8kdwro4.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="203973"; mail-complaints-to="usenet@blaine.gmane.org" To: Juri Linkov , 32344@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 21 22:55:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iMehw-000qv8-30 for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Oct 2019 22:55:16 +0200 Original-Received: from localhost ([::1]:47802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMehu-0000tf-KQ for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Oct 2019 16:55:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41744) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMegk-0007wm-Rw for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 16:54:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMegj-0002Qs-Sn for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 16:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49114) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMegj-0002Qh-Or for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 16:54:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iMegj-0002sv-L6 for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 16:54:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87h8kdwro4.fsf@gmail.com> Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Oct 2019 20:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32344 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32344-submit@debbugs.gnu.org id=B32344.157169120511032 (code B ref 32344); Mon, 21 Oct 2019 20:54:01 +0000 Original-Received: (at 32344) by debbugs.gnu.org; 21 Oct 2019 20:53:25 +0000 Original-Received: from localhost ([127.0.0.1]:57934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMeg9-0002rr-JN for submit@debbugs.gnu.org; Mon, 21 Oct 2019 16:53:25 -0400 Original-Received: from mail-yw1-f41.google.com ([209.85.161.41]:37947) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMeg7-0002re-Aj for 32344@debbugs.gnu.org; Mon, 21 Oct 2019 16:53:23 -0400 Original-Received: by mail-yw1-f41.google.com with SMTP id s6so5421189ywe.5 for <32344@debbugs.gnu.org>; Mon, 21 Oct 2019 13:53:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=tc7w2Qs14OnppMsJr6Sx3f3p95Rxzqaj3fPIEGqe2Hs=; b=jTxTypvqz9dho43tFXEnnc9e4UapE3XuoqfJCAmNxvK/zGQ3/q8Fw71iWFFEE4v8tP cXRtt7mvcDnYPK5qi5X6hb/IikozpEeKWMhAfmZEoZr4Ic6cEIvYBXApGSgKCuzZcH4f nmnIcCOXdVpSp3VLL5LZ1QDY536sxcN5Etc/Zo+VRvJVTqb3ONBPi5GPITyLvtCYhdmY GChNCfR7SOW3b9EntEBhM45MCeQIuqqCuKEsrXEcXf3pA6AvRyFfmCYtgzuTAvP86voc lGeDgZUJuJbOxqr8rAGhBmkh5tqfxbjo9UqccgI/x4g3s8SP8y+h+zwD3DrKLXz9+XtI wy+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=tc7w2Qs14OnppMsJr6Sx3f3p95Rxzqaj3fPIEGqe2Hs=; b=hjufYs1awFf7Dcm/Uszk26+YyXjuIrtJhoGjFo1eVKI+HU/dykFpEE+VBb7xzXqvi5 QE6MP/snvjZW34EQkuiamWR3MuoHi1RhEY5zNuf6fkd2QXJnotUBCBDTANcQnU7ScRGn uTn9CDCgu8f1JqnEggzKyJvxYcyKW22b4zTRy8qxrWtPR4UQzaaOTS/iXLiYBMVUSWbc D5KJ1XLxnVXgC2wOGAoaqxC5eN8oNOsqz4oaZHd9UflWOv2zCojCA2c0q5V1r63sOFXc 9ygkc/TQiC5pmXBQnT1ga+FOTGOnuheL/qmhLu3cw9MaM83mfZzpW7mvTPJzKDNsnwcF jCCg== X-Gm-Message-State: APjAAAWwVOHHJt8BbqkrvrALFAzaPSU8Y/mRG+QDi6RbYR4Nw9LnQO57 QgbGP7b0XfFiBq6qEWxu3u6yxUirnYrXPyS9n9UQwpwmDog= X-Google-Smtp-Source: APXvYqxD1EMIDL5qRo1vykSB/QcshwGpjr4NBMtoyvR2tHJVZUcHvWUaHOOjaaMAQK6yjnZkp006HqTMf9VD93fMGp8= X-Received: by 2002:a81:9a16:: with SMTP id r22mr577449ywg.277.1571691197541; Mon, 21 Oct 2019 13:53:17 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169949 Archived-At: > But I wonder if you could just replace add-text-properties with > add-face-text-property? It will keep your previous text properties > and will just merge them with the comint-highlight-input face. I'm not sure about this: > If any text in the region already has a non-nil =E2=80=98face=E2=80=99 pr= operty, those > face(s) are retained. Is the default face represented as a nil face property? Will it be overridden? In that case the mix could be ugly. In general I'd prefer to keep both paths of execution as separate as possible so as to avoid regressions.