From: Lars Ingebrigtsen <larsi@gnus.org>
To: Carlos Pita <carlosjosepita@gmail.com>
Cc: behrmann@physik.fu-berlin.de, eggert@cs.ucla.edu, 32344@debbugs.gnu.org
Subject: bug#32344: [PATCH] 26.3/27 Option to avoid comint override colorization provided by major modes
Date: Mon, 10 Aug 2020 14:51:16 +0200 [thread overview]
Message-ID: <875z9q64vv.fsf@gnus.org> (raw)
In-Reply-To: <CAELgYhfEXd+Eip5jeXxQ27kG4fsoDN1gKhnkFRyEztyXN4ZUsw@mail.gmail.com> (Carlos Pita's message of "Mon, 21 Oct 2019 17:39:18 -0300")
Carlos Pita <carlosjosepita@gmail.com> writes:
> I've merged both patches since the python.el one was trivial and
> dependent on the other and the main target of the new option.
>
> I've also rewritten the commit message following the conventions
> described in CONTRIBUTE.
>
> Here is the commit so that you can easily comment online if you so
> prefer:
> https://github.com/memeplex/emacs/commit/27acd97dfec7ecd9667a032e3a94650cb01244c1
Could you post the patch here instead? It's nice to have the proposed
patches in the bug tracker.
Anyway, while Juri's suggestion makes sense (merging faces) in general,
I think the mechanism here (making comint not do any face mangling for
the modes that do it themselves) is cleaner. So I think Carlos' patch
should be applied to Emacs.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-08-10 12:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 0:14 bug#32344: 26.1; Option to avoid comint highlighting input Carlos Pita
2018-08-02 1:19 ` bug#32344: Carlos Pita
2018-09-12 17:04 ` bug#32344: Carlos Pita
2018-09-17 16:36 ` bug#32344: (no subject) Jörg Behrmann
2019-10-13 17:18 ` bug#32344: Carlos Pita
2019-10-13 18:36 ` bug#32344: Carlos Pita
2019-10-13 19:23 ` bug#32344: Carlos Pita
2019-10-13 19:24 ` bug#32344: Carlos Pita
2019-10-13 21:53 ` bug#32344: [PATCH] 26.3/27 Option to avoid comint override colorization provided by major modes Carlos Pita
2019-10-21 20:39 ` Carlos Pita
2020-08-10 12:51 ` Lars Ingebrigtsen [this message]
2020-08-19 11:11 ` Lars Ingebrigtsen
2019-10-20 15:57 ` bug#32344: Juri Linkov
2019-10-14 17:16 ` bug#32344: [PATCH] 26.3/27 Option to avoid comint override colorization provided by major modes Gaby Launay via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-21 20:53 ` bug#32344: Add option to keep colorization in comint, use it in python.el Carlos Pita
2019-10-22 18:25 ` Carlos Pita
2019-10-22 20:37 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z9q64vv.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=32344@debbugs.gnu.org \
--cc=behrmann@physik.fu-berlin.de \
--cc=carlosjosepita@gmail.com \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).