bug#66983: [PATCH] sql.el: Let sqlite's prompt-cont-regexp accept new dynamic prompt

[Gustav Broberg <gustav.broberg@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1622 bytes --]

On Fri, Dec 15, 2023 at 2:28 AM Stefan Kangas <stefankangas@gmail.com>
wrote:

> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Ping!  Michael, can you please look into this?
> >
> >> Cc: 66983@debbugs.gnu.org
> >> Date: Fri, 10 Nov 2023 14:06:20 +0200
> >> From: Eli Zaretskii <eliz@gnu.org>
> >>
> >> > From: Gustav Broberg <gustav.broberg@gmail.com>
> >> > Date: Fri, 10 Nov 2023 10:41:03 +0100
> >> >
> >> > Patch for changing sql.el sqlite's prompt-cont-regexp to be
> compatible with SQLite 3.41.0.
> >>
> >> Thanks.
> >>
> >> Michael, any comments or suggestions?
>
> It would be nice to get this fixed already in Emacs 29.2, given that
> SQLite is so common.
>
> FWIW, if Michael doesn't have time to look into this, the patch seems to
> make sense.  It just allows a few more prompts that weren't allowed
> before.
>
> At the same time, if these are indeed the only allowed prompts:
>
>       ...>
>    `  ...>
>    '  ...>
>    "  ...>
>    /* ...>
>    (xN...> (where N is 1 to 9)
>    (.....>
>    )x!...>
>
> we could probably make something a bit more strict.  Where do we find
> the documentation for that though?  Gustav, where is that from?
>

Thanks,

Not sure if it was clear, but the regexp in my actual patch is more strict
than in my first email: ^[`'\"/() ][x*. ][1-9!. ]\\.\\.\\.>

Unfortunately I've found no documentation listing the continuation prompts
– I derived this list by inspecting the sqlite source code. For example:
https://github.com/sqlite/sqlite/blob/e98238561911f85e54af3e6f26e47c2de8d1cda1/src/shell.c.in#L583-L611

-- Gustav

[-- Attachment #2: Type: text/html, Size: 2520 bytes --]