unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, michael@mauger.com
Cc: 66983@debbugs.gnu.org, gustav.broberg@gmail.com
Subject: bug#66983: [PATCH] sql.el: Let sqlite's prompt-cont-regexp accept new dynamic prompt
Date: Thu, 14 Dec 2023 17:28:39 -0800	[thread overview]
Message-ID: <CADwFkmmFOm5N6C6jSqiE9+s23yef1RLndA7ZHQqYqjWFY_E+eQ@mail.gmail.com> (raw)
In-Reply-To: <838r6mdvzw.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

> Ping!  Michael, can you please look into this?
>
>> Cc: 66983@debbugs.gnu.org
>> Date: Fri, 10 Nov 2023 14:06:20 +0200
>> From: Eli Zaretskii <eliz@gnu.org>
>>
>> > From: Gustav Broberg <gustav.broberg@gmail.com>
>> > Date: Fri, 10 Nov 2023 10:41:03 +0100
>> >
>> > Patch for changing sql.el sqlite's prompt-cont-regexp to be compatible with SQLite 3.41.0.
>>
>> Thanks.
>>
>> Michael, any comments or suggestions?

It would be nice to get this fixed already in Emacs 29.2, given that
SQLite is so common.

FWIW, if Michael doesn't have time to look into this, the patch seems to
make sense.  It just allows a few more prompts that weren't allowed
before.

At the same time, if these are indeed the only allowed prompts:

      ...>
   `  ...>
   '  ...>
   "  ...>
   /* ...>
   (xN...> (where N is 1 to 9)
   (.....>
   )x!...>

we could probably make something a bit more strict.  Where do we find
the documentation for that though?  Gustav, where is that from?





  reply	other threads:[~2023-12-15  1:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-07 10:20 bug#66983: 29.1; sql-sqlite prompt-cont-regexp incompatible since sqlite 3.41.0 Gustav Broberg
2023-11-10  9:41 ` bug#66983: [PATCH] sql.el: Let sqlite's prompt-cont-regexp accept new dynamic prompt Gustav Broberg
2023-11-10 12:06   ` Eli Zaretskii
2023-11-25  9:26     ` Eli Zaretskii
2023-12-15  1:28       ` Stefan Kangas [this message]
2023-12-15  8:39         ` Eli Zaretskii
2023-12-15 10:05         ` Gustav Broberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmmFOm5N6C6jSqiE9+s23yef1RLndA7ZHQqYqjWFY_E+eQ@mail.gmail.com \
    --to=stefankangas@gmail.com \
    --cc=66983@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=gustav.broberg@gmail.com \
    --cc=michael@mauger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).