unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Gustav Broberg <gustav.broberg@gmail.com>
To: 66983@debbugs.gnu.org
Subject: bug#66983: 29.1; sql-sqlite prompt-cont-regexp incompatible since sqlite 3.41.0
Date: Tue, 7 Nov 2023 11:20:18 +0100	[thread overview]
Message-ID: <CAE4h+g1hsf6iysQnezt2H2fUAGKSYU1VO9pE+tSzoZZkS6ft_g@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]

The continuation prompt regexp for sql.el's sqlite product is hard coded as
"   ...> ":
http://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/progmodes/sql.el?id=a1abb6a85e6605c256595b8d7b885018e5421c28#n497

But since SQLite version 3.41.0 this prompt is no longer static but dynamic
and contains information about current context (unclosed string,
parentheses, etc.):
https://www.sqlite.org/releaselog/3_41_0.html

For example, sending a multi-line query with an unclosed string like:

  SELECT 1
  AS "two lines
  ";

will give an output like:

  SQLite version 3.44.0 2023-11-01 11:23:50
  Enter ".help" for usage hints.
  sqlite>
  "  ...> ┌───────────┐
  │ two lines │
  ├───────────┤
  │ 1         │
  └───────────┘
  Run Time: real 0.000 user 0.000118 sys 0.000076

because the continuation prompt is '"  ...> '.

Setting a custom sqlite continuation prompt regexp to match the dynamic
prompt
fixes this:

  (sql-set-product-feature 'sqlite :prompt-cont-regexp "^...\\.\\.\\.> ")

I suggest updating the regexp in sql.el to this (or some more specific)
regexp.

Thanks!
-- 
Gustav

[-- Attachment #2: Type: text/html, Size: 1606 bytes --]

             reply	other threads:[~2023-11-07 10:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-07 10:20 Gustav Broberg [this message]
2023-11-10  9:41 ` bug#66983: [PATCH] sql.el: Let sqlite's prompt-cont-regexp accept new dynamic prompt Gustav Broberg
2023-11-10 12:06   ` Eli Zaretskii
2023-11-25  9:26     ` Eli Zaretskii
2023-12-15  1:28       ` Stefan Kangas
2023-12-15  8:39         ` Eli Zaretskii
2023-12-15 10:05         ` Gustav Broberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAE4h+g1hsf6iysQnezt2H2fUAGKSYU1VO9pE+tSzoZZkS6ft_g@mail.gmail.com \
    --to=gustav.broberg@gmail.com \
    --cc=66983@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).