bug#47880: [PATCH] Don't hard-code ~/.emacs.d in rcirc.el

bug#47880: [PATCH] Don't hard-code ~/.emacs.d in rcirc.el

[Philip Kaludercic]

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]


Hard-coding a file like this should be avoided, ever since Emacs also
supports XDG-compliant configurations paths.

Other than that, it might be better to not even store this under
XDG_CONFIG_HOME but XDG_DATA_HOME, as automatically generated files are
not configurations but data.

-- 
	Philip K.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0004-lisp-net-rcirc.el-rcirc-log-directory-Use-locate-use.patch --]
[-- Type: text/x-diff, Size: 770 bytes --]

From 620384e1c9f50bcce65cec0771265297678905d2 Mon Sep 17 00:00:00 2001
From: Philip K <philipk@posteo.net>
Date: Sun, 18 Apr 2021 20:41:37 +0200
Subject: [PATCH 4/4] * lisp/net/rcirc.el (rcirc-log-directory): Use
 locate-user-emacs-file

Author:
---
 lisp/net/rcirc.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
index 7bb8ca671c..4fbc8bc4f7 100644
--- a/lisp/net/rcirc.el
+++ b/lisp/net/rcirc.el
@@ -1166,7 +1166,7 @@ rcirc-channel-p
        (or (eq (aref target 0) ?#)
            (eq (aref target 0) ?&))))
 
-(defcustom rcirc-log-directory "~/.emacs.d/rcirc-log"
+(defcustom rcirc-log-directory (locate-user-emacs-file "rcirc-log")
   "Directory to keep IRC logfiles."
   :type 'directory)
 
-- 
2.30.2

bug#47880: [PATCH] Don't hard-code ~/.emacs.d in rcirc.el

[Stefan Kangas]

tags 47880 + fixed
close 47880 28.1
thanks

Philip Kaludercic <philipk@posteo.net> writes:

> Hard-coding a file like this should be avoided, ever since Emacs also
> supports XDG-compliant configurations paths.

Thanks for the patch!  Pushed to master as commit 869e437c10.

Note that I adapted the commit message slightly and added a :version tag
to the defcustom.