From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#47880: [PATCH] Don't hard-code ~/.emacs.d in rcirc.el Date: Sun, 18 Apr 2021 19:12:07 +0000 Message-ID: <874kg3pfug.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27606"; mail-complaints-to="usenet@ciao.gmane.io" To: 47880@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 18 21:13:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lYCr5-000765-TB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Apr 2021 21:13:15 +0200 Original-Received: from localhost ([::1]:49882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYCr4-0005X1-Tq for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Apr 2021 15:13:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYCqs-0005OD-Rz for bug-gnu-emacs@gnu.org; Sun, 18 Apr 2021 15:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36297) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYCqs-0002Z1-JD for bug-gnu-emacs@gnu.org; Sun, 18 Apr 2021 15:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lYCqs-00011N-BK for bug-gnu-emacs@gnu.org; Sun, 18 Apr 2021 15:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Apr 2021 19:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47880 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16187731363861 (code B ref -1); Sun, 18 Apr 2021 19:13:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Apr 2021 19:12:16 +0000 Original-Received: from localhost ([127.0.0.1]:47843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYCq8-00010D-0V for submit@debbugs.gnu.org; Sun, 18 Apr 2021 15:12:16 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:49242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYCq6-000106-Kg for submit@debbugs.gnu.org; Sun, 18 Apr 2021 15:12:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYCq6-0004Z7-EL for bug-gnu-emacs@gnu.org; Sun, 18 Apr 2021 15:12:14 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:45323) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYCq3-00023g-NZ for bug-gnu-emacs@gnu.org; Sun, 18 Apr 2021 15:12:13 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 08023240028 for ; Sun, 18 Apr 2021 21:12:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1618773129; bh=p/ag8HkbCmDDHYCX0itjmy4AtcbZPUaYKoorzd/3qMw=; h=From:To:Subject:Date:From; b=eijMBXsD0bi1r/1BMAxtf1Dkp1I95alYtbPU5FTO/xJWLrw78cvBIdz3LqQ1nrSGY alODNboqe4oZOF+bpB4IWGKIVEo+W+U9qersOcdgmioySP14LFrJ9qS5oRfmU0kMvz KePKN0E087X1GG2ak0BJ6534h5xu/OWgQK37GLSjebfgLwWHaXTICumq3QYZdso1yx GkT3F2i4rnA+MI8ov/PHhXo+XPjgoMJ2yDCm+sLM9ttvvG/o7b6Sv00RxOXOo7kn5k lfQJFY+pdbgCWoIBc4zS/PMMFebbdPqCzE0GhQKILcsI30mKUd8cCDjI6Dm47FgKww 60MgBmPNboQ/A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FNfhS2F8cz6tmS for ; Sun, 18 Apr 2021 21:12:08 +0200 (CEST) Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_FMBLA_NEWDOM=1.499, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204398 Archived-At: --=-=-= Content-Type: text/plain Hard-coding a file like this should be avoided, ever since Emacs also supports XDG-compliant configurations paths. Other than that, it might be better to not even store this under XDG_CONFIG_HOME but XDG_DATA_HOME, as automatically generated files are not configurations but data. -- Philip K. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0004-lisp-net-rcirc.el-rcirc-log-directory-Use-locate-use.patch >From 620384e1c9f50bcce65cec0771265297678905d2 Mon Sep 17 00:00:00 2001 From: Philip K Date: Sun, 18 Apr 2021 20:41:37 +0200 Subject: [PATCH 4/4] * lisp/net/rcirc.el (rcirc-log-directory): Use locate-user-emacs-file Author: --- lisp/net/rcirc.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 7bb8ca671c..4fbc8bc4f7 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -1166,7 +1166,7 @@ rcirc-channel-p (or (eq (aref target 0) ?#) (eq (aref target 0) ?&)))) -(defcustom rcirc-log-directory "~/.emacs.d/rcirc-log" +(defcustom rcirc-log-directory (locate-user-emacs-file "rcirc-log") "Directory to keep IRC logfiles." :type 'directory) -- 2.30.2 --=-=-=--