From: stefankangas@gmail.com
To: Yuan Fu <casouri@gmail.com>
Cc: 61356@debbugs.gnu.org, "Eli Zaretskii" <eliz@gnu.org>,
"Theodor Thornhill" <theo@thornhill.no>,
"Daniel Martín" <mardani29@yahoo.es>
Subject: bug#61356: 29.0.60; wrong-type-argument in treesit-indent-region when indenting a C buffer
Date: Mon, 4 Sep 2023 12:47:13 -0700 [thread overview]
Message-ID: <CADwFkmn3Tsa7=2aM5B7cXPEMO4APCDyAgycXg6rAnzPa3WLHqQ@mail.gmail.com> (raw)
In-Reply-To: <D15F89BF-7A65-4419-9A5F-CF6BC130DFE0@gmail.com> (Yuan Fu's message of "Fri, 24 Feb 2023 21:21:11 -0800")
Yuan Fu <casouri@gmail.com> writes:
> Thanks, I applied the patch. What you observed is certainly a regression due to,
> from what I can see from profiling, c-ts-common-statement-offset. It is added
> for more accurate indenting, by going up the parse tree and “count brackets”,
> more or less. This is probably a pretty inefficient when calculating indentation
> for every line. A change I just pushed helps a bit (in a block, make the first
> child calculate indentation as before, and children after than uses the previous
> sibling’s indentation), but still not enough.
>
> I have some ideas to improve this, and get back once I have something.
It seems like the patch here was applied. Can this bug therefore be
closed, or is there more to do here?
prev parent reply other threads:[~2023-09-04 19:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m1v8kdyv6u.fsf.ref@yahoo.es>
2023-02-07 22:20 ` bug#61356: 29.0.60; wrong-type-argument in treesit-indent-region when indenting a C buffer Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-09 10:20 ` Eli Zaretskii
2023-02-25 2:24 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-25 5:21 ` Yuan Fu
2023-09-04 19:47 ` stefankangas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmn3Tsa7=2aM5B7cXPEMO4APCDyAgycXg6rAnzPa3WLHqQ@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=61356@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=mardani29@yahoo.es \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).