From: Yuan Fu <casouri@gmail.com>
To: "Daniel Martín" <mardani29@yahoo.es>
Cc: 61356@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
Theodor Thornhill <theo@thornhill.no>
Subject: bug#61356: 29.0.60; wrong-type-argument in treesit-indent-region when indenting a C buffer
Date: Fri, 24 Feb 2023 21:21:11 -0800 [thread overview]
Message-ID: <D15F89BF-7A65-4419-9A5F-CF6BC130DFE0@gmail.com> (raw)
In-Reply-To: <m17cw6jxc9.fsf@yahoo.es>
> On Feb 24, 2023, at 6:24 PM, Daniel Martín <mardani29@yahoo.es> wrote:
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> Date: Tue, 07 Feb 2023 23:20:09 +0100
>>> From: Daniel Martín via "Bug reports for GNU Emacs,
>>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>>
>>>
>>> Steps to reproduce the problem:
>>>
>>> emacs -Q
>>> C-x C-f emacs/src/xdisp.c RET
>>> M-x c-ts-mode RET
>>> C-x h
>>> TAB
>>>
>>> Expected result:
>>>
>>> The buffer is reindented.
>>>
>>> Actual results:
>>>
>>> The operation fails with this error:
>>>
>>> Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p nil)
>>> treesit-indent-region(1 1214226)
>>> indent-region(1 1214226)
>>> indent-for-tab-command(nil)
>>> funcall-interactively(indent-for-tab-command nil)
>>> call-interactively(indent-for-tab-command nil nil)
>>> command-execute(indent-for-tab-command)
>>
>> Thank you for your report.
>>
>> Yuan and Theo, could you please look into this? I briefly stepped
>> through the code involved in the problem, and it sounds like it makes
>> some assumptions regarding the nodes which are not necessarily true in
>> Real Life.
>
> c-ts-mode from the tip of the emacs-29 branch can indent xdisp.c without
> failures if I apply the patch from bug#61691 and the patch attached to
> this email message.
>
> It is very slow, though, compared to c-mode. I have a very fast machine
> and it took around 10 minutes to indent the whole file, while c-mode
> indented the file in 30-40 seconds. I guess the algorithm in
> treesit-indent-region doesn't scale very well for very big files like
> xdisp.c.
>
Thanks, I applied the patch. What you observed is certainly a regression due to, from what I can see from profiling, c-ts-common-statement-offset. It is added for more accurate indenting, by going up the parse tree and “count brackets”, more or less. This is probably a pretty inefficient when calculating indentation for every line. A change I just pushed helps a bit (in a block, make the first child calculate indentation as before, and children after than uses the previous sibling’s indentation), but still not enough.
I have some ideas to improve this, and get back once I have something.
Yuan
next prev parent reply other threads:[~2023-02-25 5:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m1v8kdyv6u.fsf.ref@yahoo.es>
2023-02-07 22:20 ` bug#61356: 29.0.60; wrong-type-argument in treesit-indent-region when indenting a C buffer Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-09 10:20 ` Eli Zaretskii
2023-02-25 2:24 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-25 5:21 ` Yuan Fu [this message]
2023-09-04 19:47 ` stefankangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D15F89BF-7A65-4419-9A5F-CF6BC130DFE0@gmail.com \
--to=casouri@gmail.com \
--cc=61356@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mardani29@yahoo.es \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).