From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: stefankangas@gmail.com Newsgroups: gmane.emacs.bugs Subject: bug#61356: 29.0.60; wrong-type-argument in treesit-indent-region when indenting a C buffer Date: Mon, 4 Sep 2023 12:47:13 -0700 Message-ID: References: <83a61nm96q.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17622"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61356@debbugs.gnu.org, Eli Zaretskii , Theodor Thornhill , Daniel =?UTF-8?Q?Mart=C3=ADn?= To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 04 21:48:08 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdFYO-0004MP-Lq for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Sep 2023 21:48:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdFYJ-0004IW-1X; Mon, 04 Sep 2023 15:48:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdFYI-0004HX-A8 for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 15:48:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdFYH-0000ew-Qg for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 15:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdFYH-0006rT-Qx for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 15:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: stefankangas@gmail.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Sep 2023 19:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61356 X-GNU-PR-Package: emacs Original-Received: via spool by 61356-submit@debbugs.gnu.org id=B61356.169385684126219 (code B ref 61356); Mon, 04 Sep 2023 19:48:01 +0000 Original-Received: (at 61356) by debbugs.gnu.org; 4 Sep 2023 19:47:21 +0000 Original-Received: from localhost ([127.0.0.1]:52652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdFXd-0006oo-E6 for submit@debbugs.gnu.org; Mon, 04 Sep 2023 15:47:21 -0400 Original-Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:48296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdFXb-0006oa-Vd for 61356@debbugs.gnu.org; Mon, 04 Sep 2023 15:47:20 -0400 Original-Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-500b0f06136so3153592e87.0 for <61356@debbugs.gnu.org>; Mon, 04 Sep 2023 12:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693856834; x=1694461634; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=kJZ8CkXdDL5pPGqUS0+S3FJhE3HmCeUytHe2Kbu3NVE=; b=m+XAO4VCNRwcSbdbiwmUAi+qXwIVyUm/6oI0BElBmkeekwzk70ZSpnzmLuKnZrAEL8 J5qx5V6hpihVRV/2+JiY+HOsiQj8KAWFGOp3czSZGXPA0gABc8PJ2pZCOs8cutpm3ROU snbj2uOTtxdNs06mR4YaVi9ezUK2UZvaZWU3IOmzsxBU4ms1nF1iEBbAEsBsor/Xf9f+ FCs7gSJJZou6hjWsJc742t8eDEprRJBkX/beViOkZpwKP8qqx+DqeJkmVqgn7XquM/4P LYYB4Uqmz5DGk1eLHovECP97kA1TUTlU2ydLDcFU/h9cq11y452TZ9vTFVdL4Lf8hzBZ ZJFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693856834; x=1694461634; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kJZ8CkXdDL5pPGqUS0+S3FJhE3HmCeUytHe2Kbu3NVE=; b=Gk8b6dRGEIsFBqriEmKL0avHYFR7cHnrkOGwLn3tjVuHATaMqWcm06+fchRQBs8HhP 2FQak/KXEOvoaRnsKoobyzJP9481eIOHbsoibfg58gDvHa6j0RISDDGH4ax09ohoJ5YI th5KpHiJoF3Un2oJ9hZ4ab4bCd+5pXnpw8f/R+fNhDluMvhX8ZgFZ5Ar5YkLqLjCWIYz Q2f6chDbGCSPKrTDqSHvuWXumlyGGn2qqhviVntTGMyB0CHToYFtDSRO9NTJt79iYb/C bxJNgrqOvaoMARZbcMZn6UXJ/cqWM2MEl1i+f0LbnSgzxnr8vjQujjTqmBYyOKt9n5Tq FPwA== X-Gm-Message-State: AOJu0YwCZ/kOTm2vU7iK8nKgdVxptSnRIRBz4/KzxGTVju9OvX74tHnl QCDS/acnQH+TWDGSirs1EvoRywVVnEcJiGtTk6c= X-Google-Smtp-Source: AGHT+IE+knzrnEJaRY+rx4uNyXMBJN+ME0b3AwKbdXDomw8KtcyXJfsU0qFUxHmUXbo6Jg4qnnx0/laGAeE9Jqycz1c= X-Received: by 2002:a05:6512:32cc:b0:500:9f7b:e6a4 with SMTP id f12-20020a05651232cc00b005009f7be6a4mr9446510lfg.32.1693856833874; Mon, 04 Sep 2023 12:47:13 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 4 Sep 2023 12:47:13 -0700 In-Reply-To: (Yuan Fu's message of "Fri, 24 Feb 2023 21:21:11 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269284 Archived-At: Yuan Fu writes: > Thanks, I applied the patch. What you observed is certainly a regression = due to, > from what I can see from profiling, c-ts-common-statement-offset. It is a= dded > for more accurate indenting, by going up the parse tree and =E2=80=9Ccoun= t brackets=E2=80=9D, > more or less. This is probably a pretty inefficient when calculating inde= ntation > for every line. A change I just pushed helps a bit (in a block, make the = first > child calculate indentation as before, and children after than uses the p= revious > sibling=E2=80=99s indentation), but still not enough. > > I have some ideas to improve this, and get back once I have something. It seems like the patch here was applied. Can this bug therefore be closed, or is there more to do here?