From: Stefan Kangas <stefankangas@gmail.com>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: 58256@debbugs.gnu.org
Subject: bug#58256: Possible mistake in recent `dired-do-flagged-delete' change
Date: Mon, 3 Oct 2022 00:30:13 +0200 [thread overview]
Message-ID: <CADwFkmmynYRzwWEMCn_+m72EBsP+yZ7+5pahZOvjLS3yLKAzHQ@mail.gmail.com> (raw)
In-Reply-To: <871qrqt0mg.fsf@gmx.net>
close 58256 29.1
thanks
Stephen Berman <stephen.berman@gmx.net> writes:
> Yeah, it looks like I mistakenly put the dolist in the 'else' clause
> instead of the 'then' clause. Thanks for catching that.
[...]
> I think doing it that way leaves the markers in the buffer, though
> probably for typical use cases that's not a problem, and it is simpler
> that way (as I noted when I posted my patch). I guess the same
> simplification can be applied to `dired-do-delete' as well.
OK. Let's stick with the more correct way and actually delete the
markers.
I've done this in commit 0d0d59b32c, and I'm closing this bug report.
prev parent reply other threads:[~2022-10-02 22:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 18:42 bug#58256: Possible mistake in recent `dired-do-flagged-delete' change Stefan Kangas
2022-10-02 19:17 ` Stefan Kangas
2022-10-02 20:46 ` Stephen Berman
2022-10-02 22:30 ` Stefan Kangas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmmynYRzwWEMCn_+m72EBsP+yZ7+5pahZOvjLS3yLKAzHQ@mail.gmail.com \
--to=stefankangas@gmail.com \
--cc=58256@debbugs.gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).