bug#58256: Possible mistake in recent `dired-do-flagged-delete' change

[Stefan Kangas <stefankangas@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

Stefan Kangas <stefankangas@gmail.com> writes:

> If so, I wonder how this code would have worked without that `dolist' so
> far, and if that line could just be removed instead?

The command seems to be working correctly with the attached patch.

Am I missing something here?

[-- Attachment #2: 0001-lisp-dired.el-dired-do-flagged-delete-Simplify.patch --]
[-- Type: text/x-diff, Size: 1313 bytes --]

From 6500b271658a7a71ff8856b2f423d87557307bbf Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Sun, 2 Oct 2022 21:08:40 +0200
Subject: [PATCH] * lisp/dired.el (dired-do-flagged-delete): Simplify.

---
 lisp/dired.el | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/lisp/dired.el b/lisp/dired.el
index b9e89292e2..7d3940832a 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -3661,19 +3661,13 @@ dired-do-flagged-delete
   (interactive)
   (let* ((dired-marker-char dired-del-marker)
 	 (regexp (dired-marker-regexp))
-	 case-fold-search markers)
+         case-fold-search)
     (if (save-excursion (goto-char (point-min))
 			(re-search-forward regexp nil t))
-	(dired-internal-do-deletions
+        (dired-internal-do-deletions
          (nreverse
-	  ;; this can't move point since ARG is nil
-	  (dired-map-over-marks (cons (dired-get-filename)
-                                      (let ((m (point-marker)))
-                                        (push m markers)
-                                        m))
-			        nil))
+          (dired-map-over-marks (cons (dired-get-filename) (point-marker)) nil))
 	 nil t)
-      (dolist (m markers) (set-marker m nil))
       (or nomessage
 	  (message "(No deletions requested)")))))
 
-- 
2.30.2