From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#58256: Possible mistake in recent `dired-do-flagged-delete' change Date: Mon, 3 Oct 2022 00:30:13 +0200 Message-ID: References: <871qrqt0mg.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24439"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58256@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 03 00:31:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1of7UU-0006Dx-Uy for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 Oct 2022 00:31:18 +0200 Original-Received: from localhost ([::1]:56994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1of7UT-0004rr-U7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Oct 2022 18:31:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1of7UF-0004rW-0O for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2022 18:31:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49204) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1of7UE-0005WR-M1 for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2022 18:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1of7UE-00026M-Di for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2022 18:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Oct 2022 22:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58256 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58256-submit@debbugs.gnu.org id=B58256.16647498218009 (code B ref 58256); Sun, 02 Oct 2022 22:31:02 +0000 Original-Received: (at 58256) by debbugs.gnu.org; 2 Oct 2022 22:30:21 +0000 Original-Received: from localhost ([127.0.0.1]:48279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of7TZ-000256-2d for submit@debbugs.gnu.org; Sun, 02 Oct 2022 18:30:21 -0400 Original-Received: from mail-oo1-f42.google.com ([209.85.161.42]:38778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of7TX-00024f-Du for 58256@debbugs.gnu.org; Sun, 02 Oct 2022 18:30:20 -0400 Original-Received: by mail-oo1-f42.google.com with SMTP id z9-20020a4a4909000000b0047651b95fbdso5711258ooa.5 for <58256@debbugs.gnu.org>; Sun, 02 Oct 2022 15:30:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date; bh=83MvBiTFWTBMPBxsjO+gKzfHHNF1GEScP9jbZxoi4m0=; b=H42QK4udJie+Yk1IBySrVwz6LBIwfB2xdV8+a9FTbogVf25sKdfSbpWo88k1gHU+nw 94WNVZuofqec1/aQcL2I9V2wMc+7/D6Y+T7VvE24IW5T2cNNfvA49sq1A2IrR+fYtGGk ItfVNLOEwTl6Q5KUZtUlSkUAiHPluy2BvjEzyqNtDye4B1fgghbO0fjEc0i0n7+pcBp7 53fdDrP8yGR4ChUGXcD7WQvBKYeWD5zY7b/yPib2r5DP94shcfgGpkLNRWCVu704aFC6 2l6ftxEQflKepOAsWwpLW1HWM8OJcOTuLTeORbHFRfo1nXMYrwcd+LFhhEDfl9Z4ktkJ GgrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date; bh=83MvBiTFWTBMPBxsjO+gKzfHHNF1GEScP9jbZxoi4m0=; b=XK8XLaUYS3efeQajTWHMZ9qkf63bUEagA4QUgd8bauFD2QXwAgb5hvdiy3924js85v o8khLJkwinYFOWoAHwEfuEBBSX9vCR/T76/Mn2IdH+GHODG4KF8zJh6J0GTC40+Cw46o 0WNI8ankXu8w15Ce0W1dmdLFjr9HvSzYloLJSGTe513vfY5Y3LZKhc2/siz+SVIqQoJ3 fkPfdGuZqYO5w3MlJ0BgTKN6z1Ito3DznhrrPlOQnYUzv374k+xoq+UfhuQe5OW/WAsw A/T/ib3FrbIrzXQ83goFEvgaTPaOCnFOnVhUd0LHIK5mNiqsyLvXUDHAYxxSRsmyUbxG CgFw== X-Gm-Message-State: ACrzQf3Dkh7+XcxMdtEnDkHQLNZNqR+ppUAfN7biqn0Q9HT5lQ9+zpr6 f/dywjb73imf4UM9ON0wNGFaj7SO1qbwid1o/sw= X-Google-Smtp-Source: AMsMyM7tL2P6tUbOJQdKrxSlAZfYHN13zhfvQhly4MGBjeOdomK7cHSQ/aZw/OM90l4JbVjhv/QCqXTlrvtKAIbRlJE= X-Received: by 2002:a9d:7c89:0:b0:655:dfb1:331c with SMTP id q9-20020a9d7c89000000b00655dfb1331cmr6790424otn.224.1664749813807; Sun, 02 Oct 2022 15:30:13 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 3 Oct 2022 00:30:13 +0200 In-Reply-To: <871qrqt0mg.fsf@gmx.net> X-Hashcash: 1:20:221002:58256@debbugs.gnu.org::kU/GQVumJHrjO3ta:2Ymz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244269 Archived-At: close 58256 29.1 thanks Stephen Berman writes: > Yeah, it looks like I mistakenly put the dolist in the 'else' clause > instead of the 'then' clause. Thanks for catching that. [...] > I think doing it that way leaves the markers in the buffer, though > probably for typical use cases that's not a problem, and it is simpler > that way (as I noted when I posted my patch). I guess the same > simplification can be applied to `dired-do-delete' as well. OK. Let's stick with the more correct way and actually delete the markers. I've done this in commit 0d0d59b32c, and I'm closing this bug report.