From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Boruch Baum <boruch_baum@gmx.com>, 47784@debbugs.gnu.org
Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED]
Date: Tue, 20 Apr 2021 19:02:26 -0500 [thread overview]
Message-ID: <CADwFkmmp1USUMx3g0RTFB3wD-OoLbvPD_oecJrbRhmQ+Z-gStA@mail.gmail.com> (raw)
In-Reply-To: <83y2des9yn.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 19 Apr 2021 16:03:12 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> > Thanks, but I don't think I understand the rationale for the second
>> > patch. What is the problem with signaling an error in those two
>> > places?
>>
>> They avoid spawning a backtrace buffer when toggle-debug-on-error is set
>> and the error is a user input error caught by a validation test within
>> an `interactive' function call.
>
> I understand that, but the same is true for every call to 'error'
> whenever debug-on-error is set. Since by default debug-on-error is
> NOT set, I don't think I agree with that part of the change. (Why do
> you even have that variable set non-nil?)
AFAIU, `user-error' is to be used when, according to its docstring:
This is like ‘error’ except that a user error (or "pilot error") comes
from an incorrect manipulation by the user, not from an actual problem.
So if that is the case here, then it should be `user-error's and
otherwise it should be plain `error's. Right?
next prev parent reply other threads:[~2021-04-21 0:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 3:31 bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Boruch Baum
2021-04-17 19:30 ` Eli Zaretskii
2021-04-19 9:24 ` Boruch Baum
2021-04-19 13:03 ` Eli Zaretskii
2021-04-19 13:27 ` Boruch Baum
2021-04-21 0:02 ` Stefan Kangas [this message]
2021-04-21 9:23 ` Eli Zaretskii
2021-05-05 13:08 ` Lars Ingebrigtsen
2021-05-05 16:40 ` Boruch Baum
2021-05-05 19:15 ` Eli Zaretskii
2021-05-05 19:40 ` Boruch Baum
2021-05-05 19:46 ` Eli Zaretskii
2021-05-06 8:10 ` Robert Pluim
2021-05-06 11:05 ` Boruch Baum
2021-05-06 8:17 ` Lars Ingebrigtsen
2021-05-06 10:16 ` Boruch Baum
2021-05-07 11:14 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmmp1USUMx3g0RTFB3wD-OoLbvPD_oecJrbRhmQ+Z-gStA@mail.gmail.com \
--to=stefan@marxist.se \
--cc=47784@debbugs.gnu.org \
--cc=boruch_baum@gmx.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).