From: Eli Zaretskii <eliz@gnu.org>
To: Boruch Baum <boruch_baum@gmx.com>
Cc: 47784@debbugs.gnu.org
Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED]
Date: Sat, 17 Apr 2021 22:30:08 +0300 [thread overview]
Message-ID: <83eef8vhdr.fsf@gnu.org> (raw)
In-Reply-To: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> (message from Boruch Baum on Wed, 14 Apr 2021 23:31:47 -0400)
> Date: Wed, 14 Apr 2021 23:31:47 -0400
> From: Boruch Baum <boruch_baum@gmx.com>
>
> Two patch files are attached.
>
> + ses-header-row.patch
>
> + Function `ses-set-header-row' was determining the current row based
> upon variable `ses--curcell', but that variable is NIL until one
> begins an operation on a cell (eg. keybindings '=', '"'), so
> navigating to a row was insufficient to select that row, and further
> generated an ERROR because the code was not expecting a NIL value for
> variable `ses--curcell'
>
> + Using function `user-error' instead of `error' doesn't spawn a
> debug session and backtrace buffer when variable
> `toggle-debug-on-error' is set.
>
> + ses-user-error.patch
>
> + Quasi-randomly replaces some calls to function `error' with
> `user-error'.
>
> + There could be many other desirable points of replacement, but these
> were some obvious ones, and without knowing whether the patch would
> be accepted at all, it's what I invested.
Thanks, but I don't think I understand the rationale for the second
patch. What is the problem with signaling an error in those two
places?
next prev parent reply other threads:[~2021-04-17 19:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 3:31 bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Boruch Baum
2021-04-17 19:30 ` Eli Zaretskii [this message]
2021-04-19 9:24 ` Boruch Baum
2021-04-19 13:03 ` Eli Zaretskii
2021-04-19 13:27 ` Boruch Baum
2021-04-21 0:02 ` Stefan Kangas
2021-04-21 9:23 ` Eli Zaretskii
2021-05-05 13:08 ` Lars Ingebrigtsen
2021-05-05 16:40 ` Boruch Baum
2021-05-05 19:15 ` Eli Zaretskii
2021-05-05 19:40 ` Boruch Baum
2021-05-05 19:46 ` Eli Zaretskii
2021-05-06 8:10 ` Robert Pluim
2021-05-06 11:05 ` Boruch Baum
2021-05-06 8:17 ` Lars Ingebrigtsen
2021-05-06 10:16 ` Boruch Baum
2021-05-07 11:14 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83eef8vhdr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=47784@debbugs.gnu.org \
--cc=boruch_baum@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).