From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Date: Tue, 20 Apr 2021 19:02:26 -0500 Message-ID: References: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> <83eef8vhdr.fsf@gnu.org> <20210419092430.zv5gorzsvn5g2cdc@E15-2016.optimum.net> <83y2des9yn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15277"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Boruch Baum , 47784@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 21 02:03:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZ0Kl-0003tt-MJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Apr 2021 02:03:11 +0200 Original-Received: from localhost ([::1]:53944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZ0Kk-0006HF-LH for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Apr 2021 20:03:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZ0Kc-0006GL-LF for bug-gnu-emacs@gnu.org; Tue, 20 Apr 2021 20:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44851) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZ0Kc-0005RI-CW for bug-gnu-emacs@gnu.org; Tue, 20 Apr 2021 20:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lZ0Kc-0000sk-8h for bug-gnu-emacs@gnu.org; Tue, 20 Apr 2021 20:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Apr 2021 00:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47784-submit@debbugs.gnu.org id=B47784.16189633563340 (code B ref 47784); Wed, 21 Apr 2021 00:03:02 +0000 Original-Received: (at 47784) by debbugs.gnu.org; 21 Apr 2021 00:02:36 +0000 Original-Received: from localhost ([127.0.0.1]:56394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZ0KB-0000ri-Qp for submit@debbugs.gnu.org; Tue, 20 Apr 2021 20:02:36 -0400 Original-Received: from mail-pf1-f178.google.com ([209.85.210.178]:33438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZ0K9-0000rN-68 for 47784@debbugs.gnu.org; Tue, 20 Apr 2021 20:02:33 -0400 Original-Received: by mail-pf1-f178.google.com with SMTP id h11so9271394pfn.0 for <47784@debbugs.gnu.org>; Tue, 20 Apr 2021 17:02:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc :content-transfer-encoding; bh=xV3AH+E4stkuNJo9hHzAnv9ZYOsoLYkW4Mo8/MjgXi8=; b=L7LwEGaFcfvM6+7xdLDQh0dkA+bW5JJVr08i+u1y0wZtnY6O+q/KIeBwhbdrqD6PPx FoiAR9eLyPWpfTHRQ1TQvxvPTTocUpBEQj5fXNK67pzKMzLiOasIrLwXQKV0QL4G9Srd Uyo08vZqvcxnE30dG7GxaP8bqBbKTZ+82q0nw87bO329Mh6rWr4RrES/L6Wpci2s5iOE /tPo3yixsqzseyAB6hkvjb47o2HE3XcPmikBYwMTNOupJG027ZYLkfaJvhW++4ulFGPz rjQlZtMIc+uc9gJt5LqzUnJO8Ugs9Sd/tqAs8d7Yai7YXXsDgsnYnQF76q8Q2UmZhVT4 c9Aw== X-Gm-Message-State: AOAM533YYGBAt0WJTTo3pt0xaC7DLqM/bCB4U0FIh4BWC+FSP99PkOvi uP2DJw25/oegqBggtYltD3K96ey8Ykujl0odFzM= X-Google-Smtp-Source: ABdhPJw3MatilCVBmQh/NXugQONeliytXJEr/9Ioqdz0lnb8j6lZtmz8Yv9vsV2F0ozaHOxgwyPfeKy53YFRkoFYmlw= X-Received: by 2002:a05:6a00:2353:b029:25c:7dc5:a718 with SMTP id j19-20020a056a002353b029025c7dc5a718mr16949201pfj.58.1618963347304; Tue, 20 Apr 2021 17:02:27 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 20 Apr 2021 19:02:26 -0500 In-Reply-To: <83y2des9yn.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 19 Apr 2021 16:03:12 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204560 Archived-At: Eli Zaretskii writes: >> > Thanks, but I don't think I understand the rationale for the second >> > patch. What is the problem with signaling an error in those two >> > places? >> >> They avoid spawning a backtrace buffer when toggle-debug-on-error is set >> and the error is a user input error caught by a validation test within >> an `interactive' function call. > > I understand that, but the same is true for every call to 'error' > whenever debug-on-error is set. Since by default debug-on-error is > NOT set, I don't think I agree with that part of the change. (Why do > you even have that variable set non-nil?) AFAIU, `user-error' is to be used when, according to its docstring: This is like =E2=80=98error=E2=80=99 except that a user error (or "pilo= t error") comes from an incorrect manipulation by the user, not from an actual problem. So if that is the case here, then it should be `user-error's and otherwise it should be plain `error's. Right?