From: Stefan Kangas <stefankangas@gmail.com>
To: Philip Kaludercic <philipk@posteo.net>
Cc: Andrey Samsonov <samsonov.box@gmail.com>,
Eli Zaretskii <eliz@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
65475@debbugs.gnu.org
Subject: bug#65475: 29.1; package-selected-packages variable is not updated when the last package is deleted
Date: Sat, 2 Sep 2023 09:28:04 -0700 [thread overview]
Message-ID: <CADwFkmmgttJ6dg5e7+gD29SP127YNJOhi3h5GfuVn4xd7-RL4A@mail.gmail.com> (raw)
In-Reply-To: <CADwFkm=CcqZ4+VUVkTux_q_MzmAP5cCV83jtNd_kqH=OPqkgaw@mail.gmail.com> (Stefan Kangas's message of "Sat, 26 Aug 2023 13:57:22 +0200")
close 65475 30.1
thanks
Stefan Kangas <stefankangas@gmail.com> writes:
>> The issue here is that `package--save-selected-packages' only updates
>> the value of `package-selected-packages', if the new value is non-nil,
>> presumably because the VALUE argument is optional,
>
> This was added in d0a5162fd825, fixing Bug#20855. Personally, I'm not
> a huge fan of that fix, as nil is clearly a valid (if infrequent)
> value here.
>
> Could something like this work?
>
> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
> index e1172d69bf0..9f97f950e64 100644
> --- a/lisp/emacs-lisp/package.el
> +++ b/lisp/emacs-lisp/package.el
> @@ -1982,7 +1982,7 @@ package--find-non-dependencies
>
> (defun package--save-selected-packages (&optional value)
> "Set and save `package-selected-packages' to VALUE."
> - (when value
> + (when (or value after-init-time)
> (setq package-selected-packages value))
> (if after-init-time
> (customize-save-variable 'package-selected-packages
> package-selected-packages)
Pushed to master as commit 610105ee81b. Andrey, could you please test
and report back?
next prev parent reply other threads:[~2023-09-02 16:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 12:02 bug#65475: 29.1; package-selected-packages variable is not updated when the last package is deleted Andrey Samsonov
2023-08-26 7:16 ` Eli Zaretskii
2023-08-26 7:30 ` Philip Kaludercic
2023-08-26 11:57 ` Stefan Kangas
2023-08-26 12:02 ` Philip Kaludercic
2023-08-26 12:07 ` Stefan Kangas
2023-09-02 16:28 ` Stefan Kangas [this message]
2023-09-04 3:24 ` Andrey Samsonov
2023-09-04 7:35 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-05 17:10 ` Philip Kaludercic
2023-09-05 17:39 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-05 22:03 ` Stefan Kangas
2023-09-10 11:57 ` Philip Kaludercic
2023-09-11 2:42 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-13 10:01 ` Philip Kaludercic
2023-09-13 14:35 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-13 14:41 ` Stefan Kangas
2023-09-14 13:09 ` Philip Kaludercic
2023-09-14 14:27 ` Stefan Kangas
2023-09-15 7:41 ` Philip Kaludercic
2023-09-21 16:31 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmmgttJ6dg5e7+gD29SP127YNJOhi3h5GfuVn4xd7-RL4A@mail.gmail.com \
--to=stefankangas@gmail.com \
--cc=65475@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=philipk@posteo.net \
--cc=samsonov.box@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).