unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Philip Kaludercic <philipk@posteo.net>,
	Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Andrey Samsonov <samsonov.box@gmail.com>,
	Eli Zaretskii <eliz@gnu.org>, Eshel Yaron <me@eshelyaron.com>,
	65475@debbugs.gnu.org
Subject: bug#65475: 29.1; package-selected-packages variable is not updated when the last package is deleted
Date: Wed, 13 Sep 2023 07:41:16 -0700	[thread overview]
Message-ID: <CADwFkm=Lukk9vhxExfyx-1FTEggMXas5EmJ3t9Rp6Xr2x78M4g@mail.gmail.com> (raw)
In-Reply-To: <8734ziv1ck.fsf@posteo.net>

Philip Kaludercic <philipk@posteo.net> writes:

>> If we really can't find a better option, we need to add a bunch of
>> comments explaining why we ended up with such a hack.
>
> It seems that it is only necessary to bind `package-alist' during the
> invocation of `package--used-elsewhere-p', so this is a more
> conservative proposal:

Any chance we could add a unit test for this?  It's been a while since I
last looked at package-tests.el.

Other than that, LGTM.





  parent reply	other threads:[~2023-09-13 14:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-23 12:02 bug#65475: 29.1; package-selected-packages variable is not updated when the last package is deleted Andrey Samsonov
2023-08-26  7:16 ` Eli Zaretskii
2023-08-26  7:30   ` Philip Kaludercic
2023-08-26 11:57     ` Stefan Kangas
2023-08-26 12:02       ` Philip Kaludercic
2023-08-26 12:07         ` Stefan Kangas
2023-09-02 16:28       ` Stefan Kangas
2023-09-04  3:24         ` Andrey Samsonov
2023-09-04  7:35           ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-05 17:10             ` Philip Kaludercic
2023-09-05 17:39               ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-05 22:03                 ` Stefan Kangas
2023-09-10 11:57                   ` Philip Kaludercic
2023-09-11  2:42                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-13 10:01                       ` Philip Kaludercic
2023-09-13 14:35                         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-13 14:41                         ` Stefan Kangas [this message]
2023-09-14 13:09                           ` Philip Kaludercic
2023-09-14 14:27                             ` Stefan Kangas
2023-09-15  7:41                               ` Philip Kaludercic
2023-09-21 16:31                                 ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=Lukk9vhxExfyx-1FTEggMXas5EmJ3t9Rp6Xr2x78M4g@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=65475@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=me@eshelyaron.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=philipk@posteo.net \
    --cc=samsonov.box@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).