From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#65475: 29.1; package-selected-packages variable is not updated when the last package is deleted Date: Sat, 2 Sep 2023 09:28:04 -0700 Message-ID: References: <61352d45-21a6-466b-be7b-7755a6260356@gmail.com> <83a5uemfxy.fsf@gnu.org> <87o7iutg4i.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9735"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andrey Samsonov , Eli Zaretskii , Stefan Monnier , 65475@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 02 18:29:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcTUs-0002J1-0s for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Sep 2023 18:29:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcTUU-0006EX-Gk; Sat, 02 Sep 2023 12:28:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcTUT-0006EG-7y for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 12:28:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcTUT-0000XP-0G for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 12:28:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcTUc-00073V-J0 for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 12:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Sep 2023 16:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65475 X-GNU-PR-Package: emacs Original-Received: via spool by 65475-submit@debbugs.gnu.org id=B65475.169367210327051 (code B ref 65475); Sat, 02 Sep 2023 16:29:02 +0000 Original-Received: (at 65475) by debbugs.gnu.org; 2 Sep 2023 16:28:23 +0000 Original-Received: from localhost ([127.0.0.1]:38357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcTTy-00072E-KA for submit@debbugs.gnu.org; Sat, 02 Sep 2023 12:28:22 -0400 Original-Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]:62589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcTTw-00071w-QE for 65475@debbugs.gnu.org; Sat, 02 Sep 2023 12:28:21 -0400 Original-Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2b72161c6e9so11646461fa.0 for <65475@debbugs.gnu.org>; Sat, 02 Sep 2023 09:28:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693672085; x=1694276885; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=jGGz9LD8b2rw7/I+c5xWq8fu/sU7Ithvy70igQ3LC1w=; b=Mtu7fNMFDgBSpVfpICHs2lxtjIWnS9jJrckcDdqrZ799hoxaP0w55LL1wjxMLLqWCM v8y7jOChO08vz8BPphS/mmGZT3qp1rs3yHWa4waENOe9pAb9v+1WB6X2/sbib8zlxbSl TFzZkijGPbUy2a2lGf/+aETupLWh4cPY90X7DovgQWKvph0Lbm6fTHS+o0Q4lDtrh2je lzFXD2DV3NjU0wv4QW9y4j+AcMru+NLG7wbCBk6LQrdwaNUffcuFHq+NVXN8j0GNcnaI o1YgCNOZ+87C32ng8xYDBsBcP0M7MtCSl8GjfXQm3U9M6E1mSCvvq+f7iNuF5/4dPkkn fYMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693672085; x=1694276885; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jGGz9LD8b2rw7/I+c5xWq8fu/sU7Ithvy70igQ3LC1w=; b=aWaI+77AYwdcC9ActQNYEemVfwGm5G1JdE0qYrYW9JFEPHv67dCIodpWZQf/2hL3Hk S9T2aVi9ECGN9dCQbxw0l+6VpeZ2XRk64S7GhSTIAldjVpvJ1NQsGOKImx4fheaG+mBQ S72LYkMoTRDPLEg5zFlIGoC/e9RVUo76LqmxzzodNle4poYhpSWYgrlLVsZuA1pPJXdb hMeObiJI6vqgk4926luuUhdwJEHlO7y1VYU3C9+7pMgEhPP9LnhQ4GmFVOJzEV+g+Sol JN8hDUMrYMETt31fFnZqNpJAIqjj9Yh+hYDBgwRfGOQw6C5zQpEpME/K9iVitv2S4YzX 4mXQ== X-Gm-Message-State: AOJu0YzhrMFNrUC5KNGuex/IRij6iT0MwLfJIFbf7v4/NL8M/x4FClh6 uo302fRxvtoHWLTxusz0AgTOQL10l/7S3uKIWgA= X-Google-Smtp-Source: AGHT+IFBcP9MoD2NNIXkRmU4+WtWeH5Kpm+dfM+FR4Gd1XyoIhY6S7f1gX2cNbBn5NNC6k8KU5fi+7z/MYclrHR3dpk= X-Received: by 2002:a05:6512:33d2:b0:500:acae:30c5 with SMTP id d18-20020a05651233d200b00500acae30c5mr3074255lfg.15.1693672084691; Sat, 02 Sep 2023 09:28:04 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 2 Sep 2023 09:28:04 -0700 In-Reply-To: (Stefan Kangas's message of "Sat, 26 Aug 2023 13:57:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269009 Archived-At: close 65475 30.1 thanks Stefan Kangas writes: >> The issue here is that `package--save-selected-packages' only updates >> the value of `package-selected-packages', if the new value is non-nil, >> presumably because the VALUE argument is optional, > > This was added in d0a5162fd825, fixing Bug#20855. Personally, I'm not > a huge fan of that fix, as nil is clearly a valid (if infrequent) > value here. > > Could something like this work? > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index e1172d69bf0..9f97f950e64 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -1982,7 +1982,7 @@ package--find-non-dependencies > > (defun package--save-selected-packages (&optional value) > "Set and save `package-selected-packages' to VALUE." > - (when value > + (when (or value after-init-time) > (setq package-selected-packages value)) > (if after-init-time > (customize-save-variable 'package-selected-packages > package-selected-packages) Pushed to master as commit 610105ee81b. Andrey, could you please test and report back?