From: Stefan Kangas <stefan@marxist.se>
To: Kevin Ryde <user42@zip.com.au>
Cc: Noam Postavsky <npostavs@gmail.com>, 15112@debbugs.gnu.org
Subject: bug#15112: 24.3; package.el byte compile autoloads
Date: Wed, 28 Aug 2019 15:15:46 +0200 [thread overview]
Message-ID: <CADwFkmmVTTgYwqrvjCZHZ-5CN+s3auP4nbnOJXcniR1zSKLzbA@mail.gmail.com> (raw)
In-Reply-To: <8738q96sb1.fsf@blah.blah>
Kevin Ryde <user42@zip.com.au> writes:
> When package.el installs a file, the foo-autoloads.el which it creates
> is not byte compiled. I hoped that it would be, because doing so allows
> the dynamic docstrings stuff to leave possibly big docstrings on disk
> until required.
>
> I see package-autoload-ensure-default-file contains
>
> ";; no-byte-compile: t\n"
>
> which is perhaps copied from autoload-rubric. Perhaps it could omit
> that to allow byte compile.
>
> I have presumed no-byte-compile in loaddefs is for the benefit of emacs'
> own loaddefs which are dumped. Perhaps for everyone else the default
> rubric could allow byte compiling.
package-autoload-ensure-default-file now uses autoload-rubric internally
and no longer contains the line quoted above with "no-byte-compile".
However, autoload-rubric still contains it.
I guess the question is if it's there for good reason or could perhaps
be omitted. If there's a good reason for it, perhaps this bug should be
closed as wontfix.
Noam, I noted that you added a comment to this particular line recently
in commit 1f7b602f84. Could you perhaps shed some light on why we use
no-byte-compile here?
Thanks,
Stefan Kangas
next prev parent reply other threads:[~2019-08-28 13:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-17 1:04 bug#15112: 24.3; package.el byte compile autoloads Kevin Ryde
2019-08-28 13:15 ` Stefan Kangas [this message]
2019-08-28 14:48 ` Noam Postavsky
2020-11-26 2:44 ` Stefan Kangas
2020-11-26 9:34 ` Michael Albinus
2020-11-26 10:18 ` Stefan Kangas
2020-11-26 11:53 ` Michael Albinus
2021-01-01 18:56 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmmVTTgYwqrvjCZHZ-5CN+s3auP4nbnOJXcniR1zSKLzbA@mail.gmail.com \
--to=stefan@marxist.se \
--cc=15112@debbugs.gnu.org \
--cc=npostavs@gmail.com \
--cc=user42@zip.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).