From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#15112: 24.3; package.el byte compile autoloads Date: Wed, 28 Aug 2019 15:15:46 +0200 Message-ID: References: <8738q96sb1.fsf@blah.blah> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="176729"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Noam Postavsky , 15112@debbugs.gnu.org To: Kevin Ryde Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 28 15:17:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i2xp1-000jre-Nr for geb-bug-gnu-emacs@m.gmane.org; Wed, 28 Aug 2019 15:17:11 +0200 Original-Received: from localhost ([::1]:36240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2xp0-00028I-G5 for geb-bug-gnu-emacs@m.gmane.org; Wed, 28 Aug 2019 09:17:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35238) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2xot-00027w-BG for bug-gnu-emacs@gnu.org; Wed, 28 Aug 2019 09:17:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2xos-0006mf-EI for bug-gnu-emacs@gnu.org; Wed, 28 Aug 2019 09:17:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41132) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i2xos-0006mV-8h for bug-gnu-emacs@gnu.org; Wed, 28 Aug 2019 09:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i2xos-0002Qf-12 for bug-gnu-emacs@gnu.org; Wed, 28 Aug 2019 09:17:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <8738q96sb1.fsf@blah.blah> Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Aug 2019 13:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15112 X-GNU-PR-Package: emacs Original-Received: via spool by 15112-submit@debbugs.gnu.org id=B15112.15669981699251 (code B ref 15112); Wed, 28 Aug 2019 13:17:01 +0000 Original-Received: (at 15112) by debbugs.gnu.org; 28 Aug 2019 13:16:09 +0000 Original-Received: from localhost ([127.0.0.1]:49953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2xo0-0002P8-Om for submit@debbugs.gnu.org; Wed, 28 Aug 2019 09:16:09 -0400 Original-Received: from mail-pf1-f176.google.com ([209.85.210.176]:37388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2xnw-0002OJ-TL for 15112@debbugs.gnu.org; Wed, 28 Aug 2019 09:16:07 -0400 Original-Received: by mail-pf1-f176.google.com with SMTP id y9so1722149pfl.4 for <15112@debbugs.gnu.org>; Wed, 28 Aug 2019 06:16:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=V9wreoc7VgP1Q/HaBvIgGBKys79ynJZaZAcUk+L+fzo=; b=nzBDQcSdcMbQeA9oUc1aTJsXpE90stqTEhN5Jo26nOZJkAoG6boW4N+UmIY8U+tjqO fPbBa99X7dXutAWXmktAJy23W6u6Bo1A3MEBvElR+/ol4r+uv9U5xhDWljmGw4a+fL3f vLUHwy/L6C0YdAe2gcnP4rBELFxsLiiNb1khmDRX2zSLDRmfz5CwsbuQW/8wQd8kNTYK k/wi2oE4MMWbPwPAr/i7LCpnxqNNUhWrXM4AzxqthXF3supR/nkRt3Vi1B9viQdKsyCh 5DZlZt8FTOhmu4Tva1aExEy+Mvc8YSaE1LmazzoJIK2z5E2UulUng0UCINZJ280vrs5U cAWw== X-Gm-Message-State: APjAAAUBq5OajhF1Oybjtlw3TPPpJnYKDvBra7M6usfb4T+/1oXBhH+c nL3I5pSedIsZJ/MNOV175+N35QCK1RL5wwIgBwo= X-Google-Smtp-Source: APXvYqxeMZ+J0+DsO+w85NzESn2tk7jpEXC2p85QTXuft384kFntquz7iL7OvTQVE6Zg175JlZpK4WnRXAXF66jKS3A= X-Received: by 2002:a63:69c1:: with SMTP id e184mr3282723pgc.198.1566998159043; Wed, 28 Aug 2019 06:15:59 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166001 Archived-At: Kevin Ryde writes: > When package.el installs a file, the foo-autoloads.el which it creates > is not byte compiled. I hoped that it would be, because doing so allows > the dynamic docstrings stuff to leave possibly big docstrings on disk > until required. > > I see package-autoload-ensure-default-file contains > > ";; no-byte-compile: t\n" > > which is perhaps copied from autoload-rubric. Perhaps it could omit > that to allow byte compile. > > I have presumed no-byte-compile in loaddefs is for the benefit of emacs' > own loaddefs which are dumped. Perhaps for everyone else the default > rubric could allow byte compiling. package-autoload-ensure-default-file now uses autoload-rubric internally and no longer contains the line quoted above with "no-byte-compile". However, autoload-rubric still contains it. I guess the question is if it's there for good reason or could perhaps be omitted. If there's a good reason for it, perhaps this bug should be closed as wontfix. Noam, I noted that you added a comment to this particular line recently in commit 1f7b602f84. Could you perhaps shed some light on why we use no-byte-compile here? Thanks, Stefan Kangas