From: Noam Postavsky <npostavs@gmail.com>
To: Stefan Kangas <stefan@marxist.se>
Cc: Kevin Ryde <user42@zip.com.au>, 15112@debbugs.gnu.org
Subject: bug#15112: 24.3; package.el byte compile autoloads
Date: Wed, 28 Aug 2019 10:48:24 -0400 [thread overview]
Message-ID: <85zhjtibwn.fsf@gmail.com> (raw)
In-Reply-To: <CADwFkmmVTTgYwqrvjCZHZ-5CN+s3auP4nbnOJXcniR1zSKLzbA@mail.gmail.com> (Stefan Kangas's message of "Wed, 28 Aug 2019 15:15:46 +0200")
Stefan Kangas <stefan@marxist.se> writes:
> package-autoload-ensure-default-file now uses autoload-rubric internally
> and no longer contains the line quoted above with "no-byte-compile".
> However, autoload-rubric still contains it.
>
> I guess the question is if it's there for good reason or could perhaps
> be omitted. If there's a good reason for it, perhaps this bug should be
> closed as wontfix.
>
> Noam, I noted that you added a comment to this particular line recently
> in commit 1f7b602f84. Could you perhaps shed some light on why we use
> no-byte-compile here?
As the comment says "#$ is byte-compiled into nil", and we use #$ in the
generated autoloaded file. So byte-compiling would break it.
I think it would work to use load-file-name instead.
next prev parent reply other threads:[~2019-08-28 14:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-17 1:04 bug#15112: 24.3; package.el byte compile autoloads Kevin Ryde
2019-08-28 13:15 ` Stefan Kangas
2019-08-28 14:48 ` Noam Postavsky [this message]
2020-11-26 2:44 ` Stefan Kangas
2020-11-26 9:34 ` Michael Albinus
2020-11-26 10:18 ` Stefan Kangas
2020-11-26 11:53 ` Michael Albinus
2021-01-01 18:56 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85zhjtibwn.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=15112@debbugs.gnu.org \
--cc=stefan@marxist.se \
--cc=user42@zip.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).