From: Stefan Kangas <stefankangas@gmail.com>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: 60830@debbugs.gnu.org, "Rudolf Adamkovič" <salutis@me.com>,
"Stefan Monnier" <monnier@iro.umontreal.ca>
Subject: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors
Date: Wed, 10 Jan 2024 09:09:11 -0800 [thread overview]
Message-ID: <CADwFkmmJ=qFP2s5YEOLmvAQS0GuPkq0yN73dn+21PCKO2bONFA@mail.gmail.com> (raw)
In-Reply-To: <4B80400D-9223-47F3-8F59-BC95C79A6DBE@gmail.com>
Mattias Engdegård <mattias.engdegard@gmail.com> writes:
> 10 jan. 2024 kl. 14.48 skrev Stefan Kangas <stefankangas@gmail.com>:
>
>> Thank you, installed on master (cd0eb055fd4) and closing the bug.
>
> Sorry for falling behind on this bug, and thank you for helping me
> catch up.
>
> However I wasn't actually finished here: the new regexps are still
> annoyingly close to other patterns that mismatches and/or bad
> performance cannot be ruled out, and it would be good to have a way to
> deal with it.
Sorry, that was a misunderstanding on my part. I thought we were done
discussing it. Feel free to revert the change and reopen the bug, or
whatever else you think makes sense here.
> I'm tempted go about disabling large swaths of rules since for every
> useful contemporary rule like Gnu, Typescript and yes, Lua, there seem
> to be a half-dozen ones for niche and/or outright antiquated tools.
>
> Anyway, I performed some minimum maintenance on the new Lua patterns
> but can't promise that they be enabled by default in the end -- it's
> not that they aren't useful but risk of interference.
If we can't even enable new patterns due to risk of interference, then
it's clear that we've dug ourselves into a hole.
How about adding a new user option `compilation-enabled-errors' where
you could disable (or enable) the ones you are interested in, and then
generate `compilation-error-regexp-alist-alist' based on that? That
would provide a convenient way for users to get back the support for
their trusty Jikes compiler or whatever. We should probably also
support using it as a directory local variable somehow, so that projects
could set this only once.
> (And it's probably high time I made a batch conversion of the
> remaining patterns to rx.)
That would help maintenance, so I'm all for it.
next prev parent reply other threads:[~2024-01-10 17:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 11:33 bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-13 14:55 ` Stefan Kangas
2023-10-02 12:04 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-02 18:37 ` Stefan Kangas
2023-10-03 8:12 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-03 9:37 ` Stefan Kangas
2023-10-03 20:03 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-05 11:27 ` Mattias Engdegård
2023-10-05 16:21 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-06 11:38 ` Mattias Engdegård
2023-10-06 13:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-06 14:00 ` Mattias Engdegård
2023-10-06 14:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-06 16:20 ` Mattias Engdegård
2023-10-06 16:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-07 11:18 ` Mattias Engdegård
2023-10-07 15:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-08 10:45 ` Mattias Engdegård
2023-10-08 14:47 ` Mattias Engdegård
2023-10-07 21:02 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-08 9:59 ` Mattias Engdegård
2023-10-12 8:12 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-12 8:17 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-12 14:32 ` Mattias Engdegård
2023-12-10 22:53 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 13:48 ` Stefan Kangas
2024-01-10 16:37 ` Mattias Engdegård
2024-01-10 17:09 ` Stefan Kangas [this message]
2024-01-10 17:45 ` Mattias Engdegård
2023-10-08 15:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-12 8:14 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmmJ=qFP2s5YEOLmvAQS0GuPkq0yN73dn+21PCKO2bONFA@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=60830@debbugs.gnu.org \
--cc=mattias.engdegard@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=salutis@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).