From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors Date: Wed, 10 Jan 2024 09:09:11 -0800 Message-ID: References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> <8170D896-5520-4A5E-83F0-51C99BD54802@gmail.com> <57BD4380-6307-469B-9DE7-FF1BCD44B679@gmail.com> <4B80400D-9223-47F3-8F59-BC95C79A6DBE@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23165"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60830@debbugs.gnu.org, Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= , Stefan Monnier To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 10 18:10:37 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNc68-0005qB-NE for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jan 2024 18:10:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNc5d-00060f-Dv; Wed, 10 Jan 2024 12:10:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNc5b-0005yu-QK for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 12:10:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNc5b-0007uu-Df for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 12:10:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNc5a-0001wg-2U for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 12:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2024 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60830 X-GNU-PR-Package: emacs Original-Received: via spool by 60830-submit@debbugs.gnu.org id=B60830.17049065597402 (code B ref 60830); Wed, 10 Jan 2024 17:10:02 +0000 Original-Received: (at 60830) by debbugs.gnu.org; 10 Jan 2024 17:09:19 +0000 Original-Received: from localhost ([127.0.0.1]:42690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNc4t-0001vJ-1T for submit@debbugs.gnu.org; Wed, 10 Jan 2024 12:09:19 -0500 Original-Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:48583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNc4r-0001v6-4O for 60830@debbugs.gnu.org; Wed, 10 Jan 2024 12:09:17 -0500 Original-Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-55719cdc0e1so4974277a12.1 for <60830@debbugs.gnu.org>; Wed, 10 Jan 2024 09:09:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704906552; x=1705511352; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=Tqcw4TQeqY/4+xXGK9NYkFlwyvgkp47vJuIX/waJIYs=; b=Kyu3wiPxL/4HcW5MLMVFL1kE5/L88D1NEAwPOypXooPfUcvM1DNIFg9Nku9sArHNtj mVNiiWhW9r1MYqUpj8V3NMw4tPwBiFQR8r7m+cuCTovYXxnVUy6wJexquUZAB4+YzEoY BPGI/5yLLNnz0bpJBbyzYFIZH3cQ9UyN8+XxaIVZTZUtSc75YzdT5upGOGRq76YjTZ01 JAckmk/72OzNpWDxPXw8rYXPKlHuPVu6R/no0OEQbLdW2DLW8kawNPIh9wGt5wgdJV87 lY7lygYbiRQvSaMGsp271NI9Ins/OGhfd1bjE0l/xR+b64AIjGCPDjmTzjyJ5rbO8Hdf DuYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704906552; x=1705511352; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Tqcw4TQeqY/4+xXGK9NYkFlwyvgkp47vJuIX/waJIYs=; b=MymqUMHfPR7DVULtJ1Kl2oJZ83fIG2pDp09gszguQuwudIWokXoxOmzqTbUjIqB8sf PvsHpSqwbpC7Kh7iajdNa2v3ZTbANPz38fJCt8ZeypVFjDrx/nO08JdktVZzrN1neklf 3fhZvX9N8pR7tkAES8XgxN2xPncefTfQhorKMtAZ3t3prM3OwMEGK8JhBGouoqW4DK9c 0v0Zgrcy3ZDAgky0DNSlUOlXuZK8RFs1PB+7+uyUymqm/8oj5GTVANsw2b5Wosk0bdrQ 1TKajBL7xCSJWy9uCfoBq/zk9oDs7jik/ZnYYRtZ5LdipBIbTzO0rYAfOFDEC7PjOEVX 5hbQ== X-Gm-Message-State: AOJu0YzbzsDv5rBXSdwunEcX41hLZziiwPcuDB9oQLDQSV/rtYB7eFXm zSveBEFkGrtaf534JdIbWh+UosqgsZeRZwEFg48= X-Google-Smtp-Source: AGHT+IEqEApUuGPeWZxJ1jUIBCrEmqkIn1sWxUR73Smma8HkBR4FpNhBYTW6+ZMSc2RWLUc6qasqhO97omPAAiUS8zE= X-Received: by 2002:a50:c349:0:b0:557:1e56:c2cb with SMTP id q9-20020a50c349000000b005571e56c2cbmr753522edb.69.1704906551805; Wed, 10 Jan 2024 09:09:11 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 10 Jan 2024 09:09:11 -0800 In-Reply-To: <4B80400D-9223-47F3-8F59-BC95C79A6DBE@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277783 Archived-At: Mattias Engdeg=C3=A5rd writes: > 10 jan. 2024 kl. 14.48 skrev Stefan Kangas : > >> Thank you, installed on master (cd0eb055fd4) and closing the bug. > > Sorry for falling behind on this bug, and thank you for helping me > catch up. > > However I wasn't actually finished here: the new regexps are still > annoyingly close to other patterns that mismatches and/or bad > performance cannot be ruled out, and it would be good to have a way to > deal with it. Sorry, that was a misunderstanding on my part. I thought we were done discussing it. Feel free to revert the change and reopen the bug, or whatever else you think makes sense here. > I'm tempted go about disabling large swaths of rules since for every > useful contemporary rule like Gnu, Typescript and yes, Lua, there seem > to be a half-dozen ones for niche and/or outright antiquated tools. > > Anyway, I performed some minimum maintenance on the new Lua patterns > but can't promise that they be enabled by default in the end -- it's > not that they aren't useful but risk of interference. If we can't even enable new patterns due to risk of interference, then it's clear that we've dug ourselves into a hole. How about adding a new user option `compilation-enabled-errors' where you could disable (or enable) the ones you are interested in, and then generate `compilation-error-regexp-alist-alist' based on that? That would provide a convenient way for users to get back the support for their trusty Jikes compiler or whatever. We should probably also support using it as a directory local variable somehow, so that projects could set this only once. > (And it's probably high time I made a batch conversion of the > remaining patterns to rx.) That would help maintenance, so I'm all for it.