From: "Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: 60830@debbugs.gnu.org, Stefan Kangas <stefankangas@gmail.com>,
Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors
Date: Thu, 12 Oct 2023 10:12:05 +0200 [thread overview]
Message-ID: <m2y1g88dka.fsf@me.com> (raw)
In-Reply-To: <8170D896-5520-4A5E-83F0-51C99BD54802@gmail.com>
Mattias Engdegård <mattias.engdegard@gmail.com> writes:
> We can help out.
To quote you, "That's the spirit!" :)
Please see the to-do comment I left in the 'compile-tests.el'. I think
we want 'compile--test-error-line' to support both positive and negative
test cases.
> Only use non-greedy operators [...]
I updated everything to my best knowledge. If the regexps are still not
good enough, please quote the problematic fragments, so that I know
exactly where the problem is.
> Maybe you should test it just in case. (You don't need a Windows
> machine to do that but it adds authenticity).
I do not understand. Are you saying that the tests I wrote are
insufficient? If so, could you please elaborate?
> Look, it's not a beauty contest. We'll do what we have to.
How do false positives and performance tie to "beauty"? I must have
miscommunicated badly. What I wanted to say is that I imagine Lua
working out of the box, hence my hunch for the most precise regexps.
>> We still detect the file path/name, which is useful.
>
> The point is that it substantially increases the risks of false
> matches. Lua needs to be a good neighbour and can't just think of its
> own needs over anything else.
The sequence of characters is fairly unique, given each stack frame must
start with a tab and then contain ": in " after the file name.
Rudy
--
"Programming reliably -- must be an activity of an undeniably
mathematical nature […] You see, mathematics is about thinking, and
doing mathematics is always trying to think as well as possible."
-- Edsger W. Dijkstra, 1981
Rudolf Adamkovič <salutis@me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia
next prev parent reply other threads:[~2023-10-12 8:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 11:33 bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-13 14:55 ` Stefan Kangas
2023-10-02 12:04 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-02 18:37 ` Stefan Kangas
2023-10-03 8:12 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-03 9:37 ` Stefan Kangas
2023-10-03 20:03 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-05 11:27 ` Mattias Engdegård
2023-10-05 16:21 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-06 11:38 ` Mattias Engdegård
2023-10-06 13:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-06 14:00 ` Mattias Engdegård
2023-10-06 14:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-06 16:20 ` Mattias Engdegård
2023-10-06 16:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-07 11:18 ` Mattias Engdegård
2023-10-07 15:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-08 10:45 ` Mattias Engdegård
2023-10-08 14:47 ` Mattias Engdegård
2023-10-07 21:02 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-08 9:59 ` Mattias Engdegård
2023-10-12 8:12 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-10-12 8:17 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-12 14:32 ` Mattias Engdegård
2023-12-10 22:53 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 13:48 ` Stefan Kangas
2024-01-10 16:37 ` Mattias Engdegård
2024-01-10 17:09 ` Stefan Kangas
2024-01-10 17:45 ` Mattias Engdegård
2023-10-08 15:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-12 8:14 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y1g88dka.fsf@me.com \
--to=bug-gnu-emacs@gnu.org \
--cc=60830@debbugs.gnu.org \
--cc=mattias.engdegard@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=salutis@me.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).