* bug#65920: 30.0.50; Missing choice for 2 options in replace.el
@ 2023-09-13 15:47 Mauro Aranda
2023-09-13 15:51 ` Mauro Aranda
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2023-09-13 15:47 UTC (permalink / raw)
To: 65920
Docstrings for list-matching-lines-face and
list-matching-lines-buffer-name-face say they allow a nil value. But
:type is just face.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#65920: 30.0.50; Missing choice for 2 options in replace.el
2023-09-13 15:47 bug#65920: 30.0.50; Missing choice for 2 options in replace.el Mauro Aranda
@ 2023-09-13 15:51 ` Mauro Aranda
2023-09-13 16:02 ` Stefan Kangas
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2023-09-13 15:51 UTC (permalink / raw)
To: 65920
[-- Attachment #1: Type: text/plain, Size: 39 bytes --]
tags 65920 patch
quit
Here's a patch.
[-- Attachment #2: 0001-Fix-defcustom-in-replace.el-Bug-65920.patch --]
[-- Type: text/x-patch, Size: 1296 bytes --]
From 159f36c36c5d9e8fa6943e9a72eaf8dc9953283e Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Wed, 13 Sep 2023 12:49:40 -0300
Subject: [PATCH] Fix defcustom in replace.el (Bug#65920)
* lisp/replace.el (list-matching-lines-face)
(list-matching-lines-buffer-name-face): Allow a nil value.
---
lisp/replace.el | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lisp/replace.el b/lisp/replace.el
index eeac734f3bd..6b06e48c384 100644
--- a/lisp/replace.el
+++ b/lisp/replace.el
@@ -1667,13 +1667,15 @@ 'list-matching-lines
(defcustom list-matching-lines-face 'match
"Face used by \\[list-matching-lines] to show the text that matches.
If the value is nil, don't highlight the matching portions specially."
- :type 'face
+ :type '(choice (const :tag "Don't highlight matching portions" nil)
+ face)
:group 'matching)
(defcustom list-matching-lines-buffer-name-face 'underline
"Face used by \\[list-matching-lines] to show the names of buffers.
If the value is nil, don't highlight the buffer names specially."
- :type 'face
+ :type '(choice (const :tag "Don't highlight buffer names" nil)
+ face)
:group 'matching)
(defcustom list-matching-lines-current-line-face 'lazy-highlight
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#65920: 30.0.50; Missing choice for 2 options in replace.el
2023-09-13 15:51 ` Mauro Aranda
@ 2023-09-13 16:02 ` Stefan Kangas
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Kangas @ 2023-09-13 16:02 UTC (permalink / raw)
To: Mauro Aranda, 65920-done
Version: 30.1
Mauro Aranda <maurooaranda@gmail.com> writes:
> Here's a patch.
Thanks, installed on master (commit 012f9c28053).
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-13 16:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-13 15:47 bug#65920: 30.0.50; Missing choice for 2 options in replace.el Mauro Aranda
2023-09-13 15:51 ` Mauro Aranda
2023-09-13 16:02 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).