unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Mauro Aranda <maurooaranda@gmail.com>
To: 65920@debbugs.gnu.org
Subject: bug#65920: 30.0.50; Missing choice for 2 options in replace.el
Date: Wed, 13 Sep 2023 12:51:19 -0300	[thread overview]
Message-ID: <e0928a9b-7b96-405a-b361-50f95f987fac@gmail.com> (raw)
In-Reply-To: <31964851-49ea-96ef-79fb-f00445d67a15@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 39 bytes --]

tags 65920 patch
quit


Here's a patch.

[-- Attachment #2: 0001-Fix-defcustom-in-replace.el-Bug-65920.patch --]
[-- Type: text/x-patch, Size: 1296 bytes --]

From 159f36c36c5d9e8fa6943e9a72eaf8dc9953283e Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Wed, 13 Sep 2023 12:49:40 -0300
Subject: [PATCH] Fix defcustom in replace.el (Bug#65920)

* lisp/replace.el (list-matching-lines-face)
(list-matching-lines-buffer-name-face): Allow a nil value.
---
 lisp/replace.el | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lisp/replace.el b/lisp/replace.el
index eeac734f3bd..6b06e48c384 100644
--- a/lisp/replace.el
+++ b/lisp/replace.el
@@ -1667,13 +1667,15 @@ 'list-matching-lines
 (defcustom list-matching-lines-face 'match
   "Face used by \\[list-matching-lines] to show the text that matches.
 If the value is nil, don't highlight the matching portions specially."
-  :type 'face
+  :type '(choice (const :tag "Don't highlight matching portions" nil)
+                 face)
   :group 'matching)
 
 (defcustom list-matching-lines-buffer-name-face 'underline
   "Face used by \\[list-matching-lines] to show the names of buffers.
 If the value is nil, don't highlight the buffer names specially."
-  :type 'face
+  :type '(choice (const :tag "Don't highlight buffer names" nil)
+                 face)
   :group 'matching)
 
 (defcustom list-matching-lines-current-line-face 'lazy-highlight
-- 
2.34.1


  reply	other threads:[~2023-09-13 15:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13 15:47 bug#65920: 30.0.50; Missing choice for 2 options in replace.el Mauro Aranda
2023-09-13 15:51 ` Mauro Aranda [this message]
2023-09-13 16:02   ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0928a9b-7b96-405a-b361-50f95f987fac@gmail.com \
    --to=maurooaranda@gmail.com \
    --cc=65920@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).