From: Stefan Kangas <stefan@marxist.se>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Reuben Thomas <rrt@sc3d.org>, 14502-done@debbugs.gnu.org
Subject: bug#14502: 24.3; dired-load-hook should not be customizable
Date: Wed, 28 Oct 2020 01:53:12 -0700 [thread overview]
Message-ID: <CADwFkmkoyM8u_AzYiGKMJM66GoObky1eCPfs_xiepvg++9=fHQ@mail.gmail.com> (raw)
In-Reply-To: <8736i32g5y.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Wed, 14 Aug 2019 21:42:17 -0700")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Reuben Thomas <rrt@sc3d.org> writes:
>
>> dired-load-hook is customizable, but dired-x's manual correctly says
>> that you should add code to your init file to load dired-x in
>> dired-load-hook. I tried customizing the hook instead, and that doesn't
>> work. As with find-file-hook (see bug #13870), I suggest that
>> dired-load-hook either be made non-customizable, or a warning added to
>> the docstring.
>
> (I'm going through old bug reports that have unfortunately gotten no
> responses yet.)
>
> I'm not sure I understand the problem, and #13870 does not talk about
> `find-file-hook'.
>
> Does it matter whether you use `add-hook' or Customize for this
> particular hook? Most hooks are customisable, surely, including
> `find-file-hook'.
We now have that:
(make-obsolete-variable 'dired-load-hook
"use `with-eval-after-load' instead." "28.1")
So I think this problem has resolved itself, and I'm closing this bug.
next prev parent reply other threads:[~2020-10-28 8:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 13:04 bug#14502: 24.3; dired-load-hook should not be customizable Reuben Thomas
2019-08-15 4:42 ` Lars Ingebrigtsen
[not found] ` <CAOnWdoh8TJRpPTiizOZf+RT=wKA45ztc+q_j+dq-9_190=gMWg@mail.gmail.com>
2019-08-16 1:29 ` Lars Ingebrigtsen
2019-08-16 8:13 ` Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-08-16 20:50 ` Lars Ingebrigtsen
2020-10-28 8:53 ` Stefan Kangas [this message]
2019-12-31 13:41 ` Mauro Aranda
2020-01-22 12:27 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmkoyM8u_AzYiGKMJM66GoObky1eCPfs_xiepvg++9=fHQ@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=14502-done@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).