From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#14502: 24.3; dired-load-hook should not be customizable Date: Wed, 28 Oct 2020 01:53:12 -0700 Message-ID: References: <87k3mirl7x.fsf@sc3d.org> <8736i32g5y.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11069"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Reuben Thomas , 14502-done@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 28 09:54:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXhDd-0002n6-Og for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Oct 2020 09:54:09 +0100 Original-Received: from localhost ([::1]:50728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXhDc-0003u6-R9 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Oct 2020 04:54:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXhDW-0003te-0p for bug-gnu-emacs@gnu.org; Wed, 28 Oct 2020 04:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35531) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXhDV-0006MS-OO for bug-gnu-emacs@gnu.org; Wed, 28 Oct 2020 04:54:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kXhDV-0004Zf-P6 for bug-gnu-emacs@gnu.org; Wed, 28 Oct 2020 04:54:01 -0400 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Oct 2020 08:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 14502 X-GNU-PR-Package: emacs Mail-Followup-To: 14502@debbugs.gnu.org, stefan@marxist.se, rrt@sc3d.org Original-Received: via spool by 14502-done@debbugs.gnu.org id=D14502.160387520117526 (code D ref 14502); Wed, 28 Oct 2020 08:54:01 +0000 Original-Received: (at 14502-done) by debbugs.gnu.org; 28 Oct 2020 08:53:21 +0000 Original-Received: from localhost ([127.0.0.1]:47075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXhCr-0004Yc-8Q for submit@debbugs.gnu.org; Wed, 28 Oct 2020 04:53:21 -0400 Original-Received: from mail-ed1-f41.google.com ([209.85.208.41]:36942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXhCp-0004YN-4w for 14502-done@debbugs.gnu.org; Wed, 28 Oct 2020 04:53:19 -0400 Original-Received: by mail-ed1-f41.google.com with SMTP id o18so4275923edq.4 for <14502-done@debbugs.gnu.org>; Wed, 28 Oct 2020 01:53:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=kiaGo8OD1kPHUhbn1jRUKwfJ3lKsdrBADaOX/v+0PEc=; b=ujHJMY1cpHdkta6wCU8qjRY9d0T5Zc8eHCifvTEqyo+3iTuNsdGRSCoUR+bHCo0pDS 7SV6jO7rRdtYBcYLTo5hj4nO3h2OlitJ1P9bFLKjY9aD6FUst6O7AB5Mp4fuDG/GT5F4 3OWiVhX4W/s3J96cOjttbSWpUVVPC5ePe9JkKMbeJmfDbMuQt7CpKEYv+gxMpn/a+3TN 5cG/nzkRQc8N2zWEqn8rKoOnufAYWrJME/ggU8Xqn/mfz1W53J4wj/3wfCpw92NZBfAi n1fT66c/c2AO5VyiDT26Zw99Mg5ARH3bbVj2lcJcSsB6wyF6WxOoj5am1xKqZGvfP0Gv QU5Q== X-Gm-Message-State: AOAM5337EZDzeWAXezCNkI1NIQJo9WO7H0GM8pcHGEwvxYkpX2YVeVzv Jchpe4GZAte4jvhNa5cBJLyngqy9A0wRV/OgMtAYczP3 X-Google-Smtp-Source: ABdhPJxpVi6hCpw46MhFqRG0UM9JtS0nUMMOPoRsFAJVa6nykDudSxKoFzr5Z3/TLyBj+dC1g8X74SGGjZLEU3S+57c= X-Received: by 2002:aa7:c694:: with SMTP id n20mr6842999edq.160.1603875193358; Wed, 28 Oct 2020 01:53:13 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 28 Oct 2020 01:53:12 -0700 In-Reply-To: <8736i32g5y.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Wed, 14 Aug 2019 21:42:17 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191826 Archived-At: Lars Ingebrigtsen writes: > Reuben Thomas writes: > >> dired-load-hook is customizable, but dired-x's manual correctly says >> that you should add code to your init file to load dired-x in >> dired-load-hook. I tried customizing the hook instead, and that doesn't >> work. As with find-file-hook (see bug #13870), I suggest that >> dired-load-hook either be made non-customizable, or a warning added to >> the docstring. > > (I'm going through old bug reports that have unfortunately gotten no > responses yet.) > > I'm not sure I understand the problem, and #13870 does not talk about > `find-file-hook'. > > Does it matter whether you use `add-hook' or Customize for this > particular hook? Most hooks are customisable, surely, including > `find-file-hook'. We now have that: (make-obsolete-variable 'dired-load-hook "use `with-eval-after-load' instead." "28.1") So I think this problem has resolved itself, and I'm closing this bug.