From: Lars Ingebrigtsen <larsi@gnus.org>
To: Reuben Thomas <rrt@sc3d.org>
Cc: 14502@debbugs.gnu.org
Subject: bug#14502: 24.3; dired-load-hook should not be customizable
Date: Thu, 15 Aug 2019 18:29:32 -0700 [thread overview]
Message-ID: <871rxlsxs3.fsf@mouse.gnus.org> (raw)
In-Reply-To: <CAOnWdoh8TJRpPTiizOZf+RT=wKA45ztc+q_j+dq-9_190=gMWg@mail.gmail.com> (Reuben Thomas's message of "Thu, 15 Aug 2019 09:07:16 +0100")
(Please keep the debbugs address in the Cc header.)
Reuben Thomas <rrt@sc3d.org> writes:
> I'm not sure I understand the problem, and #13870 does not talk about
> `find-file-hook'.
>
> Sorry, that should say #13780. The problem is that add-hook (often in
> 3rd-party code) can be in a race with custom.el.
>
> As far as this bug report goes, if you try to customize dired-load-hook to load
> dired-x, it doesn't work.
>
> Does it matter whether you use `add-hook' or Customize for this
> particular hook? Most hooks are customisable, surely, including
> `find-file-hook'.
>
> Yes, and this can cause problems. See #13780.
The problem in #13780 is that if you mix add-hook with Customize
settings of a hook, then (depending on load order), the Customize value
for the hook may overwrite those add-hooks. The solution proposed is
that one shouldn't have defcustoms on the hooks one may somehow expect
that packages add stuff to.
But dired-load-hook doesn't seem like one of those hooks, and if you
use Customize to be
(load-x)
where load-x is
(defun load-x ()
(require 'dired-x))
then surely dired-x will be loaded with dired is loaded? (Not that I've
tried myself.)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-08-16 1:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 13:04 bug#14502: 24.3; dired-load-hook should not be customizable Reuben Thomas
2019-08-15 4:42 ` Lars Ingebrigtsen
[not found] ` <CAOnWdoh8TJRpPTiizOZf+RT=wKA45ztc+q_j+dq-9_190=gMWg@mail.gmail.com>
2019-08-16 1:29 ` Lars Ingebrigtsen [this message]
2019-08-16 8:13 ` Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-08-16 20:50 ` Lars Ingebrigtsen
2020-10-28 8:53 ` Stefan Kangas
2019-12-31 13:41 ` Mauro Aranda
2020-01-22 12:27 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rxlsxs3.fsf@mouse.gnus.org \
--to=larsi@gnus.org \
--cc=14502@debbugs.gnu.org \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).