unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 51451@debbugs.gnu.org
Subject: bug#51451: image-transform-original has a misleading name
Date: Wed, 14 Sep 2022 09:52:43 -0400	[thread overview]
Message-ID: <CADwFkmkbSbxLzAjB48v3JfipvD3Mp4F2BrCxp_ZK0OgMaGCPxQ@mail.gmail.com> (raw)
In-Reply-To: <86ee7xvzwi.fsf@mail.linkov.net> (Juri Linkov's message of "Wed,  03 Nov 2021 20:48:29 +0200")

close 51451 29.1
thanks

Juri Linkov <juri@linkov.net> writes:

>>> image-transform-* commands are modifying the values of
>>> image-transform-* variables.
>>> Would you propose to rename variables as well?
>>
>> I didn't think about that, as the commands are what the user will see.
>> Maybe we should.  Do you think it would be a good idea?
>
> At least, currently there is consistency in naming of
> image-transform-* functions and variables.  Whether
> selecting such a prefix was a good choice is another question.
>
> But if you see a problem only in the name of image-transform-original,
> then it could be renamed to image-transform-set-original or maybe
> better to image-transform-reset-to-original, i.e. to something more
> descriptive, while keeping the existing name prefix.
>
> PS: renaming to image-transform-reset-to-original will also require
> renaming image-transform-reset to image-transform-reset-to-initial.

Thanks.  I've now changed this as you suggest (commit 37fe0cd358).





  parent reply	other threads:[~2022-09-14 13:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28  0:31 bug#51451: image-transform-original has a misleading name Stefan Kangas
2021-10-29 13:14 ` Lars Ingebrigtsen
     [not found] ` <87ilxdnsbu.fsf@mail.linkov.net>
2021-10-31 20:24   ` Stefan Kangas
2021-11-03 18:48     ` Juri Linkov
2021-11-03 20:16       ` Stefan Kangas
2022-09-14 13:52       ` Stefan Kangas [this message]
2022-09-14 19:11         ` Juri Linkov
2022-09-14 23:06           ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmkbSbxLzAjB48v3JfipvD3Mp4F2BrCxp_ZK0OgMaGCPxQ@mail.gmail.com \
    --to=stefankangas@gmail.com \
    --cc=51451@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).