unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: 51451@debbugs.gnu.org
Subject: bug#51451: image-transform-original has a misleading name
Date: Wed, 27 Oct 2021 17:31:48 -0700	[thread overview]
Message-ID: <CADwFkmm6C90H+24+WHkqg9qnBQGsPe9-WOGeP-dwokYLNNicqQ@mail.gmail.com> (raw)

Severity: minor

This is the docstring of `image-transform-original'.

    (image-transform-original)

    Display the current image with the original (actual) size and
    rotation.

From reading this it is clear what it does, but the command name makes
it sound like it will transform the original image.

These are the commands under the "s" key in image-mode:

    s 0             image-transform-reset
    s b             image-transform-fit-both
    s f             image-mode-fit-frame
    s h             image-transform-fit-to-height
    s m             image-transform-set-smoothing
    s o             image-transform-original
    s r             image-transform-set-rotation
    s s             image-transform-set-scale
    s w             image-transform-fit-to-width

Perhaps this would be less confusing if these commands were named
`image-display-*' instead of `image-transform-*'?

    s 0             image-display-reset-size
    s b             image-display-fit-both
    s f             image-mode-fit-frame
    s h             image-display-fit-to-height
    s m             image-display-set-smoothing
    s o             image-display-original-size
    s r             image-display-set-rotation
    s s             image-display-set-scale
    s w             image-display-fit-to-width

Doesn't that make more sense?





             reply	other threads:[~2021-10-28  0:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28  0:31 Stefan Kangas [this message]
2021-10-29 13:14 ` bug#51451: image-transform-original has a misleading name Lars Ingebrigtsen
     [not found] ` <87ilxdnsbu.fsf@mail.linkov.net>
2021-10-31 20:24   ` Stefan Kangas
2021-11-03 18:48     ` Juri Linkov
2021-11-03 20:16       ` Stefan Kangas
2022-09-14 13:52       ` Stefan Kangas
2022-09-14 19:11         ` Juri Linkov
2022-09-14 23:06           ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmm6C90H+24+WHkqg9qnBQGsPe9-WOGeP-dwokYLNNicqQ@mail.gmail.com \
    --to=stefan@marxist.se \
    --cc=51451@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).