From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#51451: image-transform-original has a misleading name Date: Wed, 14 Sep 2022 09:52:43 -0400 Message-ID: References: <87ilxdnsbu.fsf@mail.linkov.net> <86ee7xvzwi.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9015"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51451@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 14 16:34:47 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYTTS-00026e-UM for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Sep 2022 16:34:46 +0200 Original-Received: from localhost ([::1]:55886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYTTR-0001aa-Me for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Sep 2022 10:34:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYSp5-00020h-5M for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 09:53:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37264) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYSp3-0005ux-Qu for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 09:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oYSp3-0006XL-Me for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 09:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Sep 2022 13:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51451 X-GNU-PR-Package: emacs Original-Received: via spool by 51451-submit@debbugs.gnu.org id=B51451.166316357125103 (code B ref 51451); Wed, 14 Sep 2022 13:53:01 +0000 Original-Received: (at 51451) by debbugs.gnu.org; 14 Sep 2022 13:52:51 +0000 Original-Received: from localhost ([127.0.0.1]:54194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYSot-0006Wo-AP for submit@debbugs.gnu.org; Wed, 14 Sep 2022 09:52:51 -0400 Original-Received: from mail-ot1-f48.google.com ([209.85.210.48]:33478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYSor-0006WT-OT for 51451@debbugs.gnu.org; Wed, 14 Sep 2022 09:52:50 -0400 Original-Received: by mail-ot1-f48.google.com with SMTP id l7-20020a056830154700b0065563d564dfso10341680otp.0 for <51451@debbugs.gnu.org>; Wed, 14 Sep 2022 06:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:user-agent:references :in-reply-to:from:from:to:cc:subject:date; bh=tWtR1mV0TmwHtvbJg9D+/zUt8esXt34BFq1lHAYLRRs=; b=A1loSo8s7MGBLxPN61w/GcsqS42eHlCVir+ab20SqA8Yjarw2T9ZV9FyF35mvngi0z LD7no7J/3iXq1qJFqe+gcPUdEDJXLfuXOj39vRXbeWwSl6YfEm5bwQj6pZ7cIBKuPzU0 dwge/+RuUrmhMo/zeOLnCgD3MMPHzGFV8C+K76KFz/nJO3Py7SnINe2lBEhtZTa4LxW3 flT51/VTUE3g4yO4BmgslTy0KiP+ivpPFS8OU1gkIOvG+W9q1KuHVe/5O550uEtKPgYZ RTyD7C2e+vDtVbSoRcQl41+i0fcShqPA6WuxoyLodLJdoUYr/wFIrN2ctGfHAyNqmIMt 4LAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:user-agent:references :in-reply-to:from:x-gm-message-state:from:to:cc:subject:date; bh=tWtR1mV0TmwHtvbJg9D+/zUt8esXt34BFq1lHAYLRRs=; b=JJoe0F34t5SL27hG9NlQIPeqHbqQy43TSY6vC9+7YXiA5hB17dXvFivYiCc7vjjR2N U8wkv+LKvasxsLcutd0h5WNBH1rUTHYTwYXTDFzCZoVU7nICOiTbn6UgDvHzFHEia5+v eUo67G2j4rHEG47b5TRrHtpINnqBWxhWIuiq0MN4WwvEZpkd7jcZ1HmQwWqn6KJsW7JK 8Kh/x6Tjq1142pDGrlmADQLpLpZB9obJxbPBzesKJ3CCMgryqduoUYD7ZPFEK8fGLysa SOSnFoO9bp5n14th/SkFGc3T8JiIBElxQwBRePFwjMWMYMukqaCxC+5rGlb5KhdcPlVY g9FA== X-Gm-Message-State: ACgBeo29OJzIOg590pi/KbWB72BcwJDzArtOcTK6Xm9X+QJjZ3+PiwzQ EiRxdaS/o/MH6O9UBOQKqqRjiBUT8hZAeDYFIV8= X-Google-Smtp-Source: AA6agR4o0KfoZ5UCHDmCLaUgAIRJFdVuGFmSK43KSlD7wum4ntDb13Ed7M8pI0MovTrdfVep6c5M6MiNYImAdwrtd24= X-Received: by 2002:a9d:7c89:0:b0:655:dfb1:331c with SMTP id q9-20020a9d7c89000000b00655dfb1331cmr6065096otn.224.1663163564135; Wed, 14 Sep 2022 06:52:44 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 14 Sep 2022 09:52:43 -0400 In-Reply-To: <86ee7xvzwi.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 03 Nov 2021 20:48:29 +0200") X-Hashcash: 1:20:220914:51451@debbugs.gnu.org::+PtuFA8U/EtbU2Qf:5oGC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242469 Archived-At: close 51451 29.1 thanks Juri Linkov writes: >>> image-transform-* commands are modifying the values of >>> image-transform-* variables. >>> Would you propose to rename variables as well? >> >> I didn't think about that, as the commands are what the user will see. >> Maybe we should. Do you think it would be a good idea? > > At least, currently there is consistency in naming of > image-transform-* functions and variables. Whether > selecting such a prefix was a good choice is another question. > > But if you see a problem only in the name of image-transform-original, > then it could be renamed to image-transform-set-original or maybe > better to image-transform-reset-to-original, i.e. to something more > descriptive, while keeping the existing name prefix. > > PS: renaming to image-transform-reset-to-original will also require > renaming image-transform-reset to image-transform-reset-to-initial. Thanks. I've now changed this as you suggest (commit 37fe0cd358).