* bug#55986: 28.1; (setq repeat-keep-prefix t) breaks repeat-mode
@ 2022-06-15 0:22 John Bernier
2022-06-15 7:20 ` Juri Linkov
2022-12-20 17:22 ` Juri Linkov
0 siblings, 2 replies; 7+ messages in thread
From: John Bernier @ 2022-06-15 0:22 UTC (permalink / raw)
To: 55986
[-- Attachment #1: Type: text/plain, Size: 287 bytes --]
When using repeat-mode, (setq repeat-keep-prefix t) should allow a
user to keep the previously used prefix when repeating a command.
Instead, setting it to t will somehow break the repeat functionality.
'emacs -Q', reloading the init file or toggling repeat-mode off/on does
not fix it.
[-- Attachment #2: Type: text/html, Size: 410 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#55986: 28.1; (setq repeat-keep-prefix t) breaks repeat-mode
2022-06-15 0:22 bug#55986: 28.1; (setq repeat-keep-prefix t) breaks repeat-mode John Bernier
@ 2022-06-15 7:20 ` Juri Linkov
2022-06-23 18:41 ` Stefan Kangas
2022-12-20 17:22 ` Juri Linkov
1 sibling, 1 reply; 7+ messages in thread
From: Juri Linkov @ 2022-06-15 7:20 UTC (permalink / raw)
To: John Bernier; +Cc: 55986
> When using repeat-mode, (setq repeat-keep-prefix t) should allow a
> user to keep the previously used prefix when repeating a command.
> Instead, setting it to t will somehow break the repeat functionality.
> 'emacs -Q', reloading the init file or toggling repeat-mode off/on does
> not fix it.
This should be implemented in the next release.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#55986: 28.1; (setq repeat-keep-prefix t) breaks repeat-mode
2022-06-15 7:20 ` Juri Linkov
@ 2022-06-23 18:41 ` Stefan Kangas
2022-06-23 18:59 ` Juri Linkov
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Kangas @ 2022-06-23 18:41 UTC (permalink / raw)
To: Juri Linkov; +Cc: John Bernier, 55986
Juri Linkov <juri@linkov.net> writes:
>> When using repeat-mode, (setq repeat-keep-prefix t) should allow a
>> user to keep the previously used prefix when repeating a command.
>> Instead, setting it to t will somehow break the repeat functionality.
>> 'emacs -Q', reloading the init file or toggling repeat-mode off/on does
>> not fix it.
>
> This should be implemented in the next release.
Do you mean that this is already fixed on master?
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#55986: 28.1; (setq repeat-keep-prefix t) breaks repeat-mode
2022-06-23 18:41 ` Stefan Kangas
@ 2022-06-23 18:59 ` Juri Linkov
0 siblings, 0 replies; 7+ messages in thread
From: Juri Linkov @ 2022-06-23 18:59 UTC (permalink / raw)
To: Stefan Kangas; +Cc: John Bernier, 55986
forcemerge 51281 55986
thanks
>>> When using repeat-mode, (setq repeat-keep-prefix t) should allow a
>>> user to keep the previously used prefix when repeating a command.
>>> Instead, setting it to t will somehow break the repeat functionality.
>>> 'emacs -Q', reloading the init file or toggling repeat-mode off/on does
>>> not fix it.
>>
>> This should be implemented in the next release.
>
> Do you mean that this is already fixed on master?
Please see the commit ef4954b69c17831f4c8360c436352170305666ea that says:
* lisp/repeat.el (repeat-keep-prefix): Change default to nil.
'repeat-keep-prefix' doesn't yet have sufficient support
that covers all cases in bug#51281, so it's disabled now.
There is a patch in bug#51281 that was too late to install
on the release branch, and moreover it needs more work
that should be finished before the next release.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#55986: 28.1; (setq repeat-keep-prefix t) breaks repeat-mode
2021-12-01 17:58 ` Juri Linkov
@ 2022-09-05 19:40 ` Lars Ingebrigtsen
2022-10-03 19:58 ` Juri Linkov
0 siblings, 1 reply; 7+ messages in thread
From: Lars Ingebrigtsen @ 2022-09-05 19:40 UTC (permalink / raw)
To: Juri Linkov; +Cc: 51281, 55986
Juri Linkov <juri@linkov.net> writes:
> I hesitate to make such massive change in repeat.el on the release branch.
>
> I have more patches for repeat.el that I'm unsure about to push.
> One of them is a patch that allows kbd syntax for 'repeat-exit-key':
(I only skimmed these two bug reports lightly.) This was more than half
a year ago, but at least some of this hasn't been pushed yet? Are these
changes still on the planning change?
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#55986: 28.1; (setq repeat-keep-prefix t) breaks repeat-mode
2022-09-05 19:40 ` bug#55986: 28.1; (setq repeat-keep-prefix t) breaks repeat-mode Lars Ingebrigtsen
@ 2022-10-03 19:58 ` Juri Linkov
0 siblings, 0 replies; 7+ messages in thread
From: Juri Linkov @ 2022-10-03 19:58 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 51281, 55986
>> I hesitate to make such massive change in repeat.el on the release branch.
>>
>> I have more patches for repeat.el that I'm unsure about to push.
>> One of them is a patch that allows kbd syntax for 'repeat-exit-key':
>
> (I only skimmed these two bug reports lightly.) This was more than half
> a year ago, but at least some of this hasn't been pushed yet? Are these
> changes still on the planning change?
One of the patches is pushed in b374952b51, but another change is more massive.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#55986: 28.1; (setq repeat-keep-prefix t) breaks repeat-mode
2022-06-15 0:22 bug#55986: 28.1; (setq repeat-keep-prefix t) breaks repeat-mode John Bernier
2022-06-15 7:20 ` Juri Linkov
@ 2022-12-20 17:22 ` Juri Linkov
1 sibling, 0 replies; 7+ messages in thread
From: Juri Linkov @ 2022-12-20 17:22 UTC (permalink / raw)
To: John Bernier; +Cc: 55986
close 55986 29.0.60
thanks
> When using repeat-mode, (setq repeat-keep-prefix t) should allow a
> user to keep the previously used prefix when repeating a command.
> Instead, setting it to t will somehow break the repeat functionality.
> 'emacs -Q', reloading the init file or toggling repeat-mode off/on does
> not fix it.
Thanks for the bug report. The bug is fixed now, and closed.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-12-20 17:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-15 0:22 bug#55986: 28.1; (setq repeat-keep-prefix t) breaks repeat-mode John Bernier
2022-06-15 7:20 ` Juri Linkov
2022-06-23 18:41 ` Stefan Kangas
2022-06-23 18:59 ` Juri Linkov
2022-12-20 17:22 ` Juri Linkov
-- strict thread matches above, loose matches on Subject: below --
2021-10-19 7:12 bug#51281: 28.0.60; repeat-mode issues Juri Linkov
2021-10-20 17:30 ` Juri Linkov
2021-11-04 23:24 ` Lars Ingebrigtsen
2021-12-01 17:58 ` Juri Linkov
2022-09-05 19:40 ` bug#55986: 28.1; (setq repeat-keep-prefix t) breaks repeat-mode Lars Ingebrigtsen
2022-10-03 19:58 ` Juri Linkov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).