From: Stefan Kangas <stefankangas@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: Eli Zaretskii <eliz@gnu.org>, 60660-done@debbugs.gnu.org
Subject: bug#60660: Support git-formatted patches in diff-mode
Date: Wed, 10 Jan 2024 14:37:52 -0800 [thread overview]
Message-ID: <CADwFkmkafNYBE=r0W_-J9UnwrjwRss=Nc7f=QtsZfQL5b8T4ag@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmnx-ajFeBY0an2qmjKN5C-HH+b8n-+AOwjhey2+U8NCPw@mail.gmail.com> (Stefan Kangas's message of "Tue, 5 Sep 2023 16:30:46 -0700")
Stefan Kangas <stefankangas@gmail.com> writes:
> Juri Linkov <juri@linkov.net> writes:
>
>>>> This patch for emacs-29 fixes this bug, and the rest of fontification
>>>> could be implemented in master.
>>>
>>> OK for the emacs-29 branch
>>
>> Pushed to the emacs-29 branch.
>
> So is there more to do here, or should this bug be closed? I'm not sure
> if it's still needed to track the below.
>
>>> (although I'm surprised that diff-beginning-of-hunk can return
>>> a position that is not before point).
>>
>> Indeed, strange to see this in 'diff-beginning-of-hunk':
>>
>> (cond ...
>> ((re-search-backward regexp nil t)) ; In the middle of a hunk.
>> ((re-search-forward regexp nil t) ; At first hunk header.
>> =======
>>
>> Need to experiment more with this in master.
No further comments, so I'm closing this now. Please reopen if it's
needed to track the above.
prev parent reply other threads:[~2024-01-10 22:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 18:21 bug#60660: Support git-formatted patches in diff-mode Juri Linkov
2023-01-08 18:51 ` Eli Zaretskii
2023-01-09 7:54 ` Juri Linkov
2023-09-05 23:30 ` Stefan Kangas
2024-01-10 22:37 ` Stefan Kangas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmkafNYBE=r0W_-J9UnwrjwRss=Nc7f=QtsZfQL5b8T4ag@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=60660-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).