unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 60660@debbugs.gnu.org
Subject: bug#60660: Support git-formatted patches in diff-mode
Date: Sun, 08 Jan 2023 20:51:22 +0200	[thread overview]
Message-ID: <83h6x0q2qd.fsf@gnu.org> (raw)
In-Reply-To: <86mt6ssx98.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 08 Jan 2023 20:21:23 +0200)

> From: Juri Linkov <juri@linkov.net>
> Date: Sun, 08 Jan 2023 20:21:23 +0200
> 
> Currently, there is a lot of misfontification in diff-mode visiting a git patch.
> Two dashes in the signature separator are highlighted with the diff-removed face
> (the existing diff-prev-line-if-patch-separator is used for something else).
> Three dashes in the git patch header that separate a list of affected files
> are highlighted with the diff-hunk-header face, etc.
> 
> But the worst case that raises an error is when an exclamation mark is used
> at the beginning of the line in the git patch message.
> 
> This patch for emacs-29 fixes this bug, and the rest of fontification
> could be implemented in master.

OK for the emacs-29 branch (although I'm surprised that
diff-beginning-of-hunk can return a position that is not before
point).

Thanks.





  reply	other threads:[~2023-01-08 18:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-08 18:21 bug#60660: Support git-formatted patches in diff-mode Juri Linkov
2023-01-08 18:51 ` Eli Zaretskii [this message]
2023-01-09  7:54   ` Juri Linkov
2023-09-05 23:30     ` Stefan Kangas
2024-01-10 22:37       ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h6x0q2qd.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=60660@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).