From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#60660: Support git-formatted patches in diff-mode Date: Wed, 10 Jan 2024 14:37:52 -0800 Message-ID: References: <86mt6ssx98.fsf@mail.linkov.net> <83h6x0q2qd.fsf@gnu.org> <86358k6t2p.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28644"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 60660-done@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 10 23:38:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNhDE-0007D2-0m for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jan 2024 23:38:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNhD4-0003dU-Fb; Wed, 10 Jan 2024 17:38:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNhD1-0003co-W9 for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 17:38:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNhD1-0006dF-Mk for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 17:38:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNhD0-0002Un-Fh for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 17:38:02 -0500 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2024 22:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 60660 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 60660@debbugs.gnu.org, stefankangas@gmail.com, juri@linkov.net Original-Received: via spool by 60660-done@debbugs.gnu.org id=D60660.17049262799577 (code D ref 60660); Wed, 10 Jan 2024 22:38:02 +0000 Original-Received: (at 60660-done) by debbugs.gnu.org; 10 Jan 2024 22:37:59 +0000 Original-Received: from localhost ([127.0.0.1]:43497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNhCx-0002UO-3z for submit@debbugs.gnu.org; Wed, 10 Jan 2024 17:37:59 -0500 Original-Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:43078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNhCv-0002UB-BR for 60660-done@debbugs.gnu.org; Wed, 10 Jan 2024 17:37:58 -0500 Original-Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-557bfc7f7b4so6043401a12.0 for <60660-done@debbugs.gnu.org>; Wed, 10 Jan 2024 14:37:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704926273; x=1705531073; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=tR2M24DKxDTdKlaxSGFTYjf2jhCUDSdm9h5rMspHdjI=; b=eaaXTXQ34dvCzSZ7xXSdktJ2CwSUh3qDXHH3JOrz2ZjOsYF3ackrA87ZJBz0XVoaNd KlwcEcF+yKkJsPgIepFaKE8gF9sUo7mCMsifKUhEgf6fI5UjxFGI7u6kFErPeECqb5QX OuTHg/pcfbL3CeOQ7RP9f89IgxUx7lw9qR29zhiDd04RrvujkCfF7UccoOsH5pzWMnO7 bnNVS7eORYdd+yDsMPrR4u1U6fhY5ecFqBRlMAY1M/MZKITJEe4oJjoXsfYdbiSWg9xd 9DYv3FReB0+yYiGKDFzeKGoZNPMP7kWswKvmJfKryjp5SJlSbzyELsPbw5dn8/N3yCic j5uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704926273; x=1705531073; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tR2M24DKxDTdKlaxSGFTYjf2jhCUDSdm9h5rMspHdjI=; b=SiWzTRgsmx3jh/7k4o0Wlu8YxYkOvpqHo+Qot5Qi4lseYOF7C0lWsm0BJhVp/cfjM7 rlcO5+61eKjTxURwZ7kd+njzlQ/10UeBa3uT2rICbY6QkM17XJkoZSPTWN/x1kvuHZfo VsLJcct7xQZARJrRW5Oq2+q8KfZz58S7rrXkW2jjMXwNYh6up69b0ul6ynSZ0yFBweAy mHIudVYJnp2O5cDXD0GUnhtgs4rxDivf9m7pfGac72kacU6s5fvJOavao2PbKlN1ww+9 Fqf3YxiaVOiStFes0BrOFFHEhw0kKMwx3Lv/WMPvC43j51EPWiCRRpphq9F21FD5wwqU vpOQ== X-Gm-Message-State: AOJu0Ywi4kJDBIq+MF4jpZ9H9Ur2igDZkRP9e4Hm8btY4Sbh7/XW+OCl 8FVLBxcy+H/SRmhPEdLZhJ32ArHpICqVuBVDBAE= X-Google-Smtp-Source: AGHT+IGIPt83EqSpSOA45qo7g/bUc5WofZK4yXYrSDHn2Sl9n3PqeIrRm9ZnN+DPsQv/pCzXsK5YWxAt4IWE93XIcqU= X-Received: by 2002:a05:6402:503:b0:556:d522:89b6 with SMTP id m3-20020a056402050300b00556d52289b6mr147523edv.32.1704926272722; Wed, 10 Jan 2024 14:37:52 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 10 Jan 2024 14:37:52 -0800 In-Reply-To: (Stefan Kangas's message of "Tue, 5 Sep 2023 16:30:46 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277843 Archived-At: Stefan Kangas writes: > Juri Linkov writes: > >>>> This patch for emacs-29 fixes this bug, and the rest of fontification >>>> could be implemented in master. >>> >>> OK for the emacs-29 branch >> >> Pushed to the emacs-29 branch. > > So is there more to do here, or should this bug be closed? I'm not sure > if it's still needed to track the below. > >>> (although I'm surprised that diff-beginning-of-hunk can return >>> a position that is not before point). >> >> Indeed, strange to see this in 'diff-beginning-of-hunk': >> >> (cond ... >> ((re-search-backward regexp nil t)) ; In the middle of a hunk. >> ((re-search-forward regexp nil t) ; At first hunk header. >> ======= >> >> Need to experiment more with this in master. No further comments, so I'm closing this now. Please reopen if it's needed to track the above.