* bug#40003: 27.0.70; Windows build is without jansson support
@ 2020-03-09 19:53 Ivan Yonchovski
2020-03-10 3:23 ` Eli Zaretskii
0 siblings, 1 reply; 15+ messages in thread
From: Ivan Yonchovski @ 2020-03-09 19:53 UTC (permalink / raw)
To: 40003
The native json/serialization seems to be one of the important features
in the new upcomming 27 release. It will be great if the default GNU
Emacs windows build has it.
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#40003: 27.0.70; Windows build is without jansson support
2020-03-09 19:53 bug#40003: 27.0.70; Windows build is without jansson support Ivan Yonchovski
@ 2020-03-10 3:23 ` Eli Zaretskii
2020-04-14 14:47 ` Noam Postavsky
0 siblings, 1 reply; 15+ messages in thread
From: Eli Zaretskii @ 2020-03-10 3:23 UTC (permalink / raw)
To: Ivan Yonchovski, Phillip Lord; +Cc: 40003
> From: Ivan Yonchovski <yyoncho@gmail.com>
> Date: Mon, 09 Mar 2020 21:53:58 +0200
>
> The native json/serialization seems to be one of the important features
> in the new upcomming 27 release. It will be great if the default GNU
> Emacs windows build has it.
Phillip, are you looking into this? I think I reported this a few
weeks ago.
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#40003: 27.0.70; Windows build is without jansson support
2020-03-10 3:23 ` Eli Zaretskii
@ 2020-04-14 14:47 ` Noam Postavsky
2020-06-13 16:58 ` yyoncho
2020-06-22 15:53 ` Phillip Lord
0 siblings, 2 replies; 15+ messages in thread
From: Noam Postavsky @ 2020-04-14 14:47 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 40003, Ivan Yonchovski, Phillip Lord
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Ivan Yonchovski <yyoncho@gmail.com>
>> Date: Mon, 09 Mar 2020 21:53:58 +0200
>>
>> The native json/serialization seems to be one of the important features
>> in the new upcomming 27 release. It will be great if the default GNU
>> Emacs windows build has it.
>
> Phillip, are you looking into this? I think I reported this a few
> weeks ago.
As far as I can tell, just the following would do the job:
--- i/admin/nt/dist-build/build-dep-zips.py
+++ w/admin/nt/dist-build/build-dep-zips.py
@@ -32,6 +32,7 @@
PKG_REQ='''mingw-w64-x86_64-giflib
mingw-w64-x86_64-gnutls
mingw-w64-x86_64-harfbuzz
+mingw-w64-x86_64-jansson
mingw-w64-x86_64-lcms2
mingw-w64-x86_64-libjpeg-turbo
mingw-w64-x86_64-libpng
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#40003: 27.0.70; Windows build is without jansson support
2020-04-14 14:47 ` Noam Postavsky
@ 2020-06-13 16:58 ` yyoncho
2020-06-22 15:53 ` Phillip Lord
1 sibling, 0 replies; 15+ messages in thread
From: yyoncho @ 2020-06-13 16:58 UTC (permalink / raw)
To: Noam Postavsky; +Cc: 40003, Phillip Lord
[-- Attachment #1: Type: text/plain, Size: 897 bytes --]
Any update on this?
On Tue, Apr 14, 2020 at 5:47 PM Noam Postavsky <npostavs@gmail.com> wrote:
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Ivan Yonchovski <yyoncho@gmail.com>
> >> Date: Mon, 09 Mar 2020 21:53:58 +0200
> >>
> >> The native json/serialization seems to be one of the important features
> >> in the new upcomming 27 release. It will be great if the default GNU
> >> Emacs windows build has it.
> >
> > Phillip, are you looking into this? I think I reported this a few
> > weeks ago.
>
> As far as I can tell, just the following would do the job:
>
> --- i/admin/nt/dist-build/build-dep-zips.py
> +++ w/admin/nt/dist-build/build-dep-zips.py
> @@ -32,6 +32,7 @@
> PKG_REQ='''mingw-w64-x86_64-giflib
> mingw-w64-x86_64-gnutls
> mingw-w64-x86_64-harfbuzz
> +mingw-w64-x86_64-jansson
> mingw-w64-x86_64-lcms2
> mingw-w64-x86_64-libjpeg-turbo
> mingw-w64-x86_64-libpng
>
>
[-- Attachment #2: Type: text/html, Size: 1437 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#40003: 27.0.70; Windows build is without jansson support
2020-04-14 14:47 ` Noam Postavsky
2020-06-13 16:58 ` yyoncho
@ 2020-06-22 15:53 ` Phillip Lord
2020-06-22 16:13 ` Eli Zaretskii
1 sibling, 1 reply; 15+ messages in thread
From: Phillip Lord @ 2020-06-22 15:53 UTC (permalink / raw)
To: Noam Postavsky; +Cc: 40003, Ivan Yonchovski
Noam Postavsky <npostavs@gmail.com> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Ivan Yonchovski <yyoncho@gmail.com>
>>> Date: Mon, 09 Mar 2020 21:53:58 +0200
>>>
>>> The native json/serialization seems to be one of the important features
>>> in the new upcomming 27 release. It will be great if the default GNU
>>> Emacs windows build has it.
>>
>> Phillip, are you looking into this? I think I reported this a few
>> weeks ago.
>
> As far as I can tell, just the following would do the job:
>
> --- i/admin/nt/dist-build/build-dep-zips.py
> +++ w/admin/nt/dist-build/build-dep-zips.py
> @@ -32,6 +32,7 @@
> PKG_REQ='''mingw-w64-x86_64-giflib
> mingw-w64-x86_64-gnutls
> mingw-w64-x86_64-harfbuzz
> +mingw-w64-x86_64-jansson
> mingw-w64-x86_64-lcms2
> mingw-w64-x86_64-libjpeg-turbo
> mingw-w64-x86_64-libpng
Assuming that configure puts this in by default, yes, that should be it.
I am trying to build this against Emacs-28 at the moment. What test can
I run on Emacs-28 to let me know if it has worked?
After that, the decision is what to do for Emacs-27. I can add the
dependency, but it will require rebuilding the deps file which will
update *all* of the dependencies. Not a big problem in one sense, but we
are in the pre-release test phase, IIUC.
Phil
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#40003: 27.0.70; Windows build is without jansson support
2020-06-22 15:53 ` Phillip Lord
@ 2020-06-22 16:13 ` Eli Zaretskii
2020-06-22 17:24 ` Phillip Lord
0 siblings, 1 reply; 15+ messages in thread
From: Eli Zaretskii @ 2020-06-22 16:13 UTC (permalink / raw)
To: Phillip Lord; +Cc: 40003, npostavs, yyoncho
> From: Phillip Lord <phillip.lord@russet.org.uk>
> Cc: Eli Zaretskii <eliz@gnu.org>, Ivan Yonchovski <yyoncho@gmail.com>,
> 40003@debbugs.gnu.org
> Date: Mon, 22 Jun 2020 16:53:25 +0100
>
> I am trying to build this against Emacs-28 at the moment. What test can
> I run on Emacs-28 to let me know if it has worked?
cd test && make src/json-tests
If this says tests were not skipped, you've succeeded, and your Emacs
uses the libjansson library.
> After that, the decision is what to do for Emacs-27. I can add the
> dependency, but it will require rebuilding the deps file which will
> update *all* of the dependencies. Not a big problem in one sense, but we
> are in the pre-release test phase, IIUC.
I'd say go for it. I don't expect trivial changes in the dependencies
to affect Emacs.
Thanks.
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#40003: 27.0.70; Windows build is without jansson support
2020-06-22 16:13 ` Eli Zaretskii
@ 2020-06-22 17:24 ` Phillip Lord
2020-06-30 11:13 ` Phillip Lord
0 siblings, 1 reply; 15+ messages in thread
From: Phillip Lord @ 2020-06-22 17:24 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 40003, npostavs, yyoncho
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Phillip Lord <phillip.lord@russet.org.uk>
>> Cc: Eli Zaretskii <eliz@gnu.org>, Ivan Yonchovski <yyoncho@gmail.com>,
>> 40003@debbugs.gnu.org
>> Date: Mon, 22 Jun 2020 16:53:25 +0100
>>
>> I am trying to build this against Emacs-28 at the moment. What test can
>> I run on Emacs-28 to let me know if it has worked?
>
> cd test && make src/json-tests
>
> If this says tests were not skipped, you've succeeded, and your Emacs
> uses the libjansson library.
Ah!
(fboundp 'json-serialize)
>> After that, the decision is what to do for Emacs-27. I can add the
>> dependency, but it will require rebuilding the deps file which will
>> update *all* of the dependencies. Not a big problem in one sense, but we
>> are in the pre-release test phase, IIUC.
>
> I'd say go for it. I don't expect trivial changes in the dependencies
> to affect Emacs.
Okay. I've updated by deps files. Will have to wait for emacs-27.0.92 to
come out till the next upload.
Phil
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#40003: 27.0.70; Windows build is without jansson support
2020-06-22 17:24 ` Phillip Lord
@ 2020-06-30 11:13 ` Phillip Lord
2020-06-30 14:26 ` Eli Zaretskii
2020-08-23 12:34 ` Stefan Kangas
0 siblings, 2 replies; 15+ messages in thread
From: Phillip Lord @ 2020-06-30 11:13 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 40003, npostavs, yyoncho
Phillip Lord <phillip.lord@russet.org.uk> writes:
>
> Ah!
>
> (fboundp 'json-serialize)
>
>
>
>>> After that, the decision is what to do for Emacs-27. I can add the
>>> dependency, but it will require rebuilding the deps file which will
>>> update *all* of the dependencies. Not a big problem in one sense, but we
>>> are in the pre-release test phase, IIUC.
>>
>> I'd say go for it. I don't expect trivial changes in the dependencies
>> to affect Emacs.
>
>
> Okay. I've updated by deps files. Will have to wait for emacs-27.0.92 to
> come out till the next upload.
I have pushed a snapshot release of emacs-28 to alpha which contains
this support as far as I can tell. "As far as I can tell" means
(fboundp 'json-serialize)
so any slightly more rigourous testing of this build against a real
world use case would be appreciated.
https://alpha.gnu.org/gnu/emacs/pretest/windows/emacs-28/
Phil
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#40003: 27.0.70; Windows build is without jansson support
2020-06-30 11:13 ` Phillip Lord
@ 2020-06-30 14:26 ` Eli Zaretskii
2020-06-30 20:56 ` phillip.lord
2020-08-23 12:34 ` Stefan Kangas
1 sibling, 1 reply; 15+ messages in thread
From: Eli Zaretskii @ 2020-06-30 14:26 UTC (permalink / raw)
To: Phillip Lord; +Cc: 40003, npostavs, yyoncho
> From: Phillip Lord <phillip.lord@russet.org.uk>
> Cc: 40003@debbugs.gnu.org, npostavs@gmail.com, yyoncho@gmail.com
> Date: Tue, 30 Jun 2020 12:13:05 +0100
>
> I have pushed a snapshot release of emacs-28 to alpha which contains
> this support as far as I can tell.
Thanks.
> "As far as I can tell" means
>
> (fboundp 'json-serialize)
>
> so any slightly more rigourous testing of this build against a real
> world use case would be appreciated.
There's a small test suite in test/src/json-tests.el.
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#40003: 27.0.70; Windows build is without jansson support
2020-06-30 14:26 ` Eli Zaretskii
@ 2020-06-30 20:56 ` phillip.lord
2020-06-30 21:04 ` yyoncho
0 siblings, 1 reply; 15+ messages in thread
From: phillip.lord @ 2020-06-30 20:56 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 40003, npostavs, yyoncho
On 2020-06-30 15:26, Eli Zaretskii wrote:
>> From: Phillip Lord <phillip.lord@russet.org.uk>
>> Cc: 40003@debbugs.gnu.org, npostavs@gmail.com, yyoncho@gmail.com
>> Date: Tue, 30 Jun 2020 12:13:05 +0100
>>
>> I have pushed a snapshot release of emacs-28 to alpha which contains
>> this support as far as I can tell.
>
> Thanks.
>
>> "As far as I can tell" means
>>
>> (fboundp 'json-serialize)
>>
>> so any slightly more rigourous testing of this build against a real
>> world use case would be appreciated.
>
> There's a small test suite in test/src/json-tests.el.
Yes, I know, but the test suite tests the build and not the packaged
version. We don't have any way to check that automatically.
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#40003: 27.0.70; Windows build is without jansson support
2020-06-30 20:56 ` phillip.lord
@ 2020-06-30 21:04 ` yyoncho
2020-07-01 14:13 ` Phillip Lord
0 siblings, 1 reply; 15+ messages in thread
From: yyoncho @ 2020-06-30 21:04 UTC (permalink / raw)
To: Phillip Lord; +Cc: 40003, Noam Postavsky
[-- Attachment #1: Type: text/plain, Size: 894 bytes --]
FWIW a few lsp-mode users tested the build and it works as expected.
Thanks,
Ivan
On Tue, Jun 30, 2020 at 11:56 PM <phillip.lord@russet.org.uk> wrote:
> On 2020-06-30 15:26, Eli Zaretskii wrote:
> >> From: Phillip Lord <phillip.lord@russet.org.uk>
> >> Cc: 40003@debbugs.gnu.org, npostavs@gmail.com, yyoncho@gmail.com
> >> Date: Tue, 30 Jun 2020 12:13:05 +0100
> >>
> >> I have pushed a snapshot release of emacs-28 to alpha which contains
> >> this support as far as I can tell.
> >
> > Thanks.
> >
> >> "As far as I can tell" means
> >>
> >> (fboundp 'json-serialize)
> >>
> >> so any slightly more rigourous testing of this build against a real
> >> world use case would be appreciated.
> >
> > There's a small test suite in test/src/json-tests.el.
>
> Yes, I know, but the test suite tests the build and not the packaged
> version. We don't have any way to check that automatically.
>
[-- Attachment #2: Type: text/html, Size: 1638 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#40003: 27.0.70; Windows build is without jansson support
2020-06-30 21:04 ` yyoncho
@ 2020-07-01 14:13 ` Phillip Lord
0 siblings, 0 replies; 15+ messages in thread
From: Phillip Lord @ 2020-07-01 14:13 UTC (permalink / raw)
To: yyoncho; +Cc: 40003, Noam Postavsky
It's worth a lot! Thanks for the info.
Phil
yyoncho <yyoncho@gmail.com> writes:
> FWIW a few lsp-mode users tested the build and it works as expected.
>
> Thanks,
> Ivan
>
> On Tue, Jun 30, 2020 at 11:56 PM <phillip.lord@russet.org.uk> wrote:
>
>> On 2020-06-30 15:26, Eli Zaretskii wrote:
>> >> From: Phillip Lord <phillip.lord@russet.org.uk>
>> >> Cc: 40003@debbugs.gnu.org, npostavs@gmail.com, yyoncho@gmail.com
>> >> Date: Tue, 30 Jun 2020 12:13:05 +0100
>> >>
>> >> I have pushed a snapshot release of emacs-28 to alpha which contains
>> >> this support as far as I can tell.
>> >
>> > Thanks.
>> >
>> >> "As far as I can tell" means
>> >>
>> >> (fboundp 'json-serialize)
>> >>
>> >> so any slightly more rigourous testing of this build against a real
>> >> world use case would be appreciated.
>> >
>> > There's a small test suite in test/src/json-tests.el.
>>
>> Yes, I know, but the test suite tests the build and not the packaged
>> version. We don't have any way to check that automatically.
>>
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#40003: 27.0.70; Windows build is without jansson support
2020-06-30 11:13 ` Phillip Lord
2020-06-30 14:26 ` Eli Zaretskii
@ 2020-08-23 12:34 ` Stefan Kangas
2020-08-23 15:12 ` phillip.lord
1 sibling, 1 reply; 15+ messages in thread
From: Stefan Kangas @ 2020-08-23 12:34 UTC (permalink / raw)
To: Phillip Lord; +Cc: 40003, npostavs, yyoncho
Phillip Lord <phillip.lord@russet.org.uk> writes:
> I have pushed a snapshot release of emacs-28 to alpha which contains
> this support as far as I can tell. "As far as I can tell" means
>
> (fboundp 'json-serialize)
>
> so any slightly more rigourous testing of this build against a real
> world use case would be appreciated.
It seems like the issue with missing jansson support has been resolved?
Is there anything more to do here or should this bug be closed?
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 15+ messages in thread
* bug#40003: 27.0.70; Windows build is without jansson support
2020-08-23 12:34 ` Stefan Kangas
@ 2020-08-23 15:12 ` phillip.lord
2020-08-23 16:12 ` Stefan Kangas
0 siblings, 1 reply; 15+ messages in thread
From: phillip.lord @ 2020-08-23 15:12 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 40003, npostavs, yyoncho
On 2020-08-23 13:34, Stefan Kangas wrote:
> Phillip Lord <phillip.lord@russet.org.uk> writes:
>
>> I have pushed a snapshot release of emacs-28 to alpha which contains
>> this support as far as I can tell. "As far as I can tell" means
>>
>> (fboundp 'json-serialize)
>>
>> so any slightly more rigourous testing of this build against a real
>> world use case would be appreciated.
>
> It seems like the issue with missing jansson support has been resolved?
> Is there anything more to do here or should this bug be closed?
>
> Best regards,
> Stefan Kangas
I think it can be. Strictly the bug is "windows build for Emacs-27 not
released yet".
My last comment is wrong, though. It should say "a release of emacs-27
to alpha".
Phil
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2020-08-23 16:12 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-09 19:53 bug#40003: 27.0.70; Windows build is without jansson support Ivan Yonchovski
2020-03-10 3:23 ` Eli Zaretskii
2020-04-14 14:47 ` Noam Postavsky
2020-06-13 16:58 ` yyoncho
2020-06-22 15:53 ` Phillip Lord
2020-06-22 16:13 ` Eli Zaretskii
2020-06-22 17:24 ` Phillip Lord
2020-06-30 11:13 ` Phillip Lord
2020-06-30 14:26 ` Eli Zaretskii
2020-06-30 20:56 ` phillip.lord
2020-06-30 21:04 ` yyoncho
2020-07-01 14:13 ` Phillip Lord
2020-08-23 12:34 ` Stefan Kangas
2020-08-23 15:12 ` phillip.lord
2020-08-23 16:12 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).