bug#40003: 27.0.70; Windows build is without jansson support

bug#40003: 27.0.70; Windows build is without jansson support

[Ivan Yonchovski]

The native json/serialization seems to be one of the important features
in the new upcomming 27 release. It will be great if the default GNU
Emacs windows build has it.

bug#40003: 27.0.70; Windows build is without jansson support

[Eli Zaretskii]

> From: Ivan Yonchovski <yyoncho@gmail.com>
> Date: Mon, 09 Mar 2020 21:53:58 +0200
> 
> The native json/serialization seems to be one of the important features
> in the new upcomming 27 release. It will be great if the default GNU
> Emacs windows build has it.

Phillip, are you looking into this?  I think I reported this a few
weeks ago.

bug#40003: 27.0.70; Windows build is without jansson support

[Noam Postavsky]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Ivan Yonchovski <yyoncho@gmail.com>
>> Date: Mon, 09 Mar 2020 21:53:58 +0200
>> 
>> The native json/serialization seems to be one of the important features
>> in the new upcomming 27 release. It will be great if the default GNU
>> Emacs windows build has it.
>
> Phillip, are you looking into this?  I think I reported this a few
> weeks ago.

As far as I can tell, just the following would do the job:

--- i/admin/nt/dist-build/build-dep-zips.py
+++ w/admin/nt/dist-build/build-dep-zips.py
@@ -32,6 +32,7 @@
 PKG_REQ='''mingw-w64-x86_64-giflib
 mingw-w64-x86_64-gnutls
 mingw-w64-x86_64-harfbuzz
+mingw-w64-x86_64-jansson
 mingw-w64-x86_64-lcms2
 mingw-w64-x86_64-libjpeg-turbo
 mingw-w64-x86_64-libpng

bug#40003: 27.0.70; Windows build is without jansson support

[yyoncho]

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

Any update on this?

On Tue, Apr 14, 2020 at 5:47 PM Noam Postavsky <npostavs@gmail.com> wrote:

> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Ivan Yonchovski <yyoncho@gmail.com>
> >> Date: Mon, 09 Mar 2020 21:53:58 +0200
> >>
> >> The native json/serialization seems to be one of the important features
> >> in the new upcomming 27 release. It will be great if the default GNU
> >> Emacs windows build has it.
> >
> > Phillip, are you looking into this?  I think I reported this a few
> > weeks ago.
>
> As far as I can tell, just the following would do the job:
>
> --- i/admin/nt/dist-build/build-dep-zips.py
> +++ w/admin/nt/dist-build/build-dep-zips.py
> @@ -32,6 +32,7 @@
>  PKG_REQ='''mingw-w64-x86_64-giflib
>  mingw-w64-x86_64-gnutls
>  mingw-w64-x86_64-harfbuzz
> +mingw-w64-x86_64-jansson
>  mingw-w64-x86_64-lcms2
>  mingw-w64-x86_64-libjpeg-turbo
>  mingw-w64-x86_64-libpng
>
>

[-- Attachment #2: Type: text/html, Size: 1437 bytes --]

bug#40003: 27.0.70; Windows build is without jansson support

[Phillip Lord]

Noam Postavsky <npostavs@gmail.com> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Ivan Yonchovski <yyoncho@gmail.com>
>>> Date: Mon, 09 Mar 2020 21:53:58 +0200
>>> 
>>> The native json/serialization seems to be one of the important features
>>> in the new upcomming 27 release. It will be great if the default GNU
>>> Emacs windows build has it.
>>
>> Phillip, are you looking into this?  I think I reported this a few
>> weeks ago.
>
> As far as I can tell, just the following would do the job:
>
> --- i/admin/nt/dist-build/build-dep-zips.py
> +++ w/admin/nt/dist-build/build-dep-zips.py
> @@ -32,6 +32,7 @@
>  PKG_REQ='''mingw-w64-x86_64-giflib
>  mingw-w64-x86_64-gnutls
>  mingw-w64-x86_64-harfbuzz
> +mingw-w64-x86_64-jansson
>  mingw-w64-x86_64-lcms2
>  mingw-w64-x86_64-libjpeg-turbo
>  mingw-w64-x86_64-libpng


Assuming that configure puts this in by default, yes, that should be it.

I am trying to build this against Emacs-28 at the moment. What test can
I run on Emacs-28 to let me know if it has worked?

After that, the decision is what to do for Emacs-27. I can add the
dependency, but it will require rebuilding the deps file which will
update *all* of the dependencies. Not a big problem in one sense, but we
are in the pre-release test phase, IIUC.

Phil

bug#40003: 27.0.70; Windows build is without jansson support

[Eli Zaretskii]

> From: Phillip Lord <phillip.lord@russet.org.uk>
> Cc: Eli Zaretskii <eliz@gnu.org>,  Ivan Yonchovski <yyoncho@gmail.com>,
>   40003@debbugs.gnu.org
> Date: Mon, 22 Jun 2020 16:53:25 +0100
> 
> I am trying to build this against Emacs-28 at the moment. What test can
> I run on Emacs-28 to let me know if it has worked?

  cd test && make src/json-tests

If this says tests were not skipped, you've succeeded, and your Emacs
uses the libjansson library.

> After that, the decision is what to do for Emacs-27. I can add the
> dependency, but it will require rebuilding the deps file which will
> update *all* of the dependencies. Not a big problem in one sense, but we
> are in the pre-release test phase, IIUC.

I'd say go for it.  I don't expect trivial changes in the dependencies
to affect Emacs.

Thanks.

bug#40003: 27.0.70; Windows build is without jansson support

[Phillip Lord]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Phillip Lord <phillip.lord@russet.org.uk>
>> Cc: Eli Zaretskii <eliz@gnu.org>,  Ivan Yonchovski <yyoncho@gmail.com>,
>>   40003@debbugs.gnu.org
>> Date: Mon, 22 Jun 2020 16:53:25 +0100
>> 
>> I am trying to build this against Emacs-28 at the moment. What test can
>> I run on Emacs-28 to let me know if it has worked?
>
>   cd test && make src/json-tests
>
> If this says tests were not skipped, you've succeeded, and your Emacs
> uses the libjansson library.

Ah!

(fboundp 'json-serialize)



>> After that, the decision is what to do for Emacs-27. I can add the
>> dependency, but it will require rebuilding the deps file which will
>> update *all* of the dependencies. Not a big problem in one sense, but we
>> are in the pre-release test phase, IIUC.
>
> I'd say go for it.  I don't expect trivial changes in the dependencies
> to affect Emacs.


Okay. I've updated by deps files. Will have to wait for emacs-27.0.92 to
come out till the next upload.

Phil

bug#40003: 27.0.70; Windows build is without jansson support

[Phillip Lord]

Phillip Lord <phillip.lord@russet.org.uk> writes:
>
> Ah!
>
> (fboundp 'json-serialize)
>
>
>
>>> After that, the decision is what to do for Emacs-27. I can add the
>>> dependency, but it will require rebuilding the deps file which will
>>> update *all* of the dependencies. Not a big problem in one sense, but we
>>> are in the pre-release test phase, IIUC.
>>
>> I'd say go for it.  I don't expect trivial changes in the dependencies
>> to affect Emacs.
>
>
> Okay. I've updated by deps files. Will have to wait for emacs-27.0.92 to
> come out till the next upload.


I have pushed a snapshot release of emacs-28 to alpha which contains
this support as far as I can tell. "As far as I can tell" means

(fboundp 'json-serialize)

so any slightly more rigourous testing of this build against a real
world use case would be appreciated.

https://alpha.gnu.org/gnu/emacs/pretest/windows/emacs-28/


Phil

bug#40003: 27.0.70; Windows build is without jansson support

[Eli Zaretskii]

> From: Phillip Lord <phillip.lord@russet.org.uk>
> Cc: 40003@debbugs.gnu.org,  npostavs@gmail.com,  yyoncho@gmail.com
> Date: Tue, 30 Jun 2020 12:13:05 +0100
> 
> I have pushed a snapshot release of emacs-28 to alpha which contains
> this support as far as I can tell.

Thanks.

> "As far as I can tell" means
> 
> (fboundp 'json-serialize)
> 
> so any slightly more rigourous testing of this build against a real
> world use case would be appreciated.

There's a small test suite in test/src/json-tests.el.

bug#40003: 27.0.70; Windows build is without jansson support

[phillip.lord]

On 2020-06-30 15:26, Eli Zaretskii wrote:
>> From: Phillip Lord <phillip.lord@russet.org.uk>
>> Cc: 40003@debbugs.gnu.org,  npostavs@gmail.com,  yyoncho@gmail.com
>> Date: Tue, 30 Jun 2020 12:13:05 +0100
>> 
>> I have pushed a snapshot release of emacs-28 to alpha which contains
>> this support as far as I can tell.
> 
> Thanks.
> 
>> "As far as I can tell" means
>> 
>> (fboundp 'json-serialize)
>> 
>> so any slightly more rigourous testing of this build against a real
>> world use case would be appreciated.
> 
> There's a small test suite in test/src/json-tests.el.

Yes, I know, but the test suite tests the build and not the packaged 
version. We don't have any way to check that automatically.

bug#40003: 27.0.70; Windows build is without jansson support

[yyoncho]

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]

FWIW a few lsp-mode users tested the build and it works as expected.

Thanks,
Ivan

On Tue, Jun 30, 2020 at 11:56 PM <phillip.lord@russet.org.uk> wrote:

> On 2020-06-30 15:26, Eli Zaretskii wrote:
> >> From: Phillip Lord <phillip.lord@russet.org.uk>
> >> Cc: 40003@debbugs.gnu.org,  npostavs@gmail.com,  yyoncho@gmail.com
> >> Date: Tue, 30 Jun 2020 12:13:05 +0100
> >>
> >> I have pushed a snapshot release of emacs-28 to alpha which contains
> >> this support as far as I can tell.
> >
> > Thanks.
> >
> >> "As far as I can tell" means
> >>
> >> (fboundp 'json-serialize)
> >>
> >> so any slightly more rigourous testing of this build against a real
> >> world use case would be appreciated.
> >
> > There's a small test suite in test/src/json-tests.el.
>
> Yes, I know, but the test suite tests the build and not the packaged
> version. We don't have any way to check that automatically.
>

[-- Attachment #2: Type: text/html, Size: 1638 bytes --]

bug#40003: 27.0.70; Windows build is without jansson support

[Phillip Lord]

It's worth a lot! Thanks for the info.

Phil

yyoncho <yyoncho@gmail.com> writes:

> FWIW a few lsp-mode users tested the build and it works as expected.
>
> Thanks,
> Ivan
>
> On Tue, Jun 30, 2020 at 11:56 PM <phillip.lord@russet.org.uk> wrote:
>
>> On 2020-06-30 15:26, Eli Zaretskii wrote:
>> >> From: Phillip Lord <phillip.lord@russet.org.uk>
>> >> Cc: 40003@debbugs.gnu.org,  npostavs@gmail.com,  yyoncho@gmail.com
>> >> Date: Tue, 30 Jun 2020 12:13:05 +0100
>> >>
>> >> I have pushed a snapshot release of emacs-28 to alpha which contains
>> >> this support as far as I can tell.
>> >
>> > Thanks.
>> >
>> >> "As far as I can tell" means
>> >>
>> >> (fboundp 'json-serialize)
>> >>
>> >> so any slightly more rigourous testing of this build against a real
>> >> world use case would be appreciated.
>> >
>> > There's a small test suite in test/src/json-tests.el.
>>
>> Yes, I know, but the test suite tests the build and not the packaged
>> version. We don't have any way to check that automatically.
>>

bug#40003: 27.0.70; Windows build is without jansson support

[Stefan Kangas]

Phillip Lord <phillip.lord@russet.org.uk> writes:

> I have pushed a snapshot release of emacs-28 to alpha which contains
> this support as far as I can tell. "As far as I can tell" means
>
> (fboundp 'json-serialize)
>
> so any slightly more rigourous testing of this build against a real
> world use case would be appreciated.

It seems like the issue with missing jansson support has been resolved?
Is there anything more to do here or should this bug be closed?

Best regards,
Stefan Kangas

bug#40003: 27.0.70; Windows build is without jansson support

[phillip.lord]

On 2020-08-23 13:34, Stefan Kangas wrote:
> Phillip Lord <phillip.lord@russet.org.uk> writes:
> 
>> I have pushed a snapshot release of emacs-28 to alpha which contains
>> this support as far as I can tell. "As far as I can tell" means
>> 
>> (fboundp 'json-serialize)
>> 
>> so any slightly more rigourous testing of this build against a real
>> world use case would be appreciated.
> 
> It seems like the issue with missing jansson support has been resolved?
> Is there anything more to do here or should this bug be closed?
> 
> Best regards,
> Stefan Kangas

I think it can be. Strictly the bug is "windows build for Emacs-27 not 
released yet".

My last comment is wrong, though. It should say "a release of emacs-27 
to alpha".

Phil

bug#40003: 27.0.70; Windows build is without jansson support

[Stefan Kangas]

phillip.lord@russet.org.uk writes:

>> Is there anything more to do here or should this bug be closed?
>
> I think it can be.

Thanks.  I'm therefore closing this bug report.

Best regards,
Stefan Kangas