From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Date: Tue, 5 Sep 2023 16:36:59 -0700 Message-ID: References: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> <40d31b3d-d429-5a48-02bc-a3c1e4a1d903@gmail.com> <8f725450-1158-67de-7a0f-d550d867e084@gmail.com> <990abf69-d2f9-7582-c4dd-fd6bdebf04b3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4677"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60845@debbugs.gnu.org, Stefan Monnier To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 06 01:38:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdfci-00013Y-BV for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Sep 2023 01:38:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdfcT-00058h-39; Tue, 05 Sep 2023 19:38:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdfcQ-00058R-3L for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 19:38:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdfcP-0001qb-RX for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 19:38:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdfcQ-0002Ny-Fe for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 19:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Sep 2023 23:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60845-submit@debbugs.gnu.org id=B60845.16939570289098 (code B ref 60845); Tue, 05 Sep 2023 23:38:02 +0000 Original-Received: (at 60845) by debbugs.gnu.org; 5 Sep 2023 23:37:08 +0000 Original-Received: from localhost ([127.0.0.1]:59829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdfbY-0002Mf-FH for submit@debbugs.gnu.org; Tue, 05 Sep 2023 19:37:08 -0400 Original-Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]:56823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdfbW-0002Lw-MO for 60845@debbugs.gnu.org; Tue, 05 Sep 2023 19:37:07 -0400 Original-Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-50098cc8967so4843017e87.1 for <60845@debbugs.gnu.org>; Tue, 05 Sep 2023 16:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693957020; x=1694561820; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=mQMqb+sWGsiHF5FmvKkqU3moOyY6XS77mEhPfzXTtO4=; b=Phq8WUWefvjpOPI/GGTUFWBJCXuBztmXn/mgiw+ccBt59gE8RD8Xp42CKKSvUjuprt CDaXlSbUza1LfyarORnuHPDiCPD4O49jpLtM4wOOaVx0aXGpd1LITMcqT2fJsu06T/0V Bnsf02sGhek77EvbiqhtLOorHMmdHapCHuYRvBSy364SYg59KRu5QDQMXH5VACym58i9 C/8SxMXgmm4gkZqgHuvLo0AuOg7TPpAuFeSevxT15JGiuLFeJGaQHe92ZZJHhOfJv3dO EZS8pCMltxHxKRMFRyw10upog2I27VfLnEbrNP9+dqX7SgGoc4edWPQozis0DAHBUou2 8t/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693957020; x=1694561820; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mQMqb+sWGsiHF5FmvKkqU3moOyY6XS77mEhPfzXTtO4=; b=L4qHDmoUzuONq1lljQq5kCSJTIzCAb9es3fchqC5Gm8vKY8ZV1vGCQM2wnfauOGBzW my62sfuInrJQcv58Mu+GoreCdB3Yg+a5bP+zYzwl5ao6rLw2j0Vh2OyJBGViwpAPXb06 LmRF7bWwtBow8nZBAQrxs8XDqITYKulH2tsObhPDVWZ4YMEOYKTvt4gXhkyab/++CCL7 ym9Aq0JL/Aby6Aj3GMIOS8zwZNDPOg82twcUR0fGS5tS50waVhKL6jRYpMNs9zSVzcXq q7EOu8i5GApLVUPePSLxvpbklKuuInInBOc139KAdX/fP4fBz4KTiqr98MrG4aitTAJw xSWw== X-Gm-Message-State: AOJu0YzEtttrhqAvioRXEF17nwS7fyz6z6leGvg4V7cRVrV93s4gP+C5 YyRsvNRDTL/Bzy37S0lI0MOPdSeN2u0fltV0Q+4= X-Google-Smtp-Source: AGHT+IEAGxWZIvR261//VV++cRIcSGyKL0MVNjdAbnq05ltwGAzCjveu9csUg+J90igqU1Ff8EPfqf1R5TQ6xSuySNI= X-Received: by 2002:a19:750f:0:b0:4fb:7b4c:d38c with SMTP id y15-20020a19750f000000b004fb7b4cd38cmr754831lfe.60.1693957019885; Tue, 05 Sep 2023 16:36:59 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 5 Sep 2023 16:36:59 -0700 In-Reply-To: <990abf69-d2f9-7582-c4dd-fd6bdebf04b3@gmail.com> (Jim Porter's message of "Mon, 30 Jan 2023 18:00:33 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269434 Archived-At: Jim Porter writes: > On 1/30/2023 6:54 AM, Stefan Monnier via Bug reports for GNU Emacs, the Swiss > army knife of text editors wrote: >> It sounds good to me, but I'm definitely not well versed in this aspect >> of the interaction between Eshell and Pcomplete (more specifically, >> this is a part of their interaction which I find quite tricky), so it's >> good that you add corresponding regression tests. > > Thanks for taking a look. I've merged my patches as e7d0aa248e. We can leave > this open though to discuss what to do about the Pcomplete side of things. I > think we can remove the workaround for Emacs 29, but maybe we want some > additional changes. That was 9 months ago. Is it still relevant to keep this bug open? > (It would also be nice to add some more Pcomplete support on the Eshell > side. For example, when completing arguments to 'echo', Pcomplete shows options > for the real /bin/echo, instead of showing options for the built-in function > 'eshell/echo'.)