From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: jared@finder.org, 68334@debbugs.gnu.org
Subject: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals
Date: Tue, 9 Jan 2024 11:08:46 -0800 [thread overview]
Message-ID: <CADwFkm=DTF+9Frx+q+jXy44-=FCikcE2d4UT4kdmZ6c7B6Y3pg@mail.gmail.com> (raw)
In-Reply-To: <8334v6pc68.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> I didn't intend to propose including the existing implementation as is,
>> which I hadn't looked closely at. Having done that just now, it seems
>> like it's implemented on the tab bar, as Juri has pointed out. I think
>> this is probably not the right thing for a feature in Emacs itself.
>
> How else do you expect this to be implemented on TTY frames? It can
> either overwrite parts of the menu bar, or it could overwrite parts of
> the tab bar. Something's gotta give, no?
>
> I also don't understand why the tab bar is deemed more important than
> the tool bar. Let's let users decide what they prefer. (Of course,
> if there's a way to let them have the cake and eat it, too, that would
> be the best.)
>
>> This feature would be most useful as a first class feature, but that
>> might require C changes.
>
> IMO, usurping one more screen line from TTY frames could be
> problematic, especially on terminals that display a relatively small
> number of lines.
You could add another line, so that you could use the tab-bar and the
tool-bar at the same time. That would provide the most flexibility for
users, I think. They would themselves get to decide how many lines to
sacrifice. (Many users also have huge screens these days, including
vertical ones.)
That said, I don't at all object to the current implementation as an
optional feature in core, if you think it's a good idea. There's no
reason to allow perfect to be the enemy of the good.
next prev parent reply other threads:[~2024-01-09 19:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 21:39 bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-08 23:04 ` bug#68334: window-tool-bar (bug#68334) Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-09 13:06 ` Eli Zaretskii
2024-01-09 4:57 ` bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals Stefan Kangas
2024-01-09 7:58 ` Juri Linkov
2024-01-09 13:13 ` Eli Zaretskii
2024-01-09 18:39 ` Stefan Kangas
2024-01-09 18:57 ` Eli Zaretskii
2024-01-09 19:08 ` Stefan Kangas [this message]
2024-01-09 19:28 ` Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-09 19:56 ` Eli Zaretskii
2024-01-10 7:24 ` Juri Linkov
2024-01-09 12:40 ` Eli Zaretskii
2024-01-10 22:59 ` Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-11 10:51 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=DTF+9Frx+q+jXy44-=FCikcE2d4UT4kdmZ6c7B6Y3pg@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=68334@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jared@finder.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).