From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals Date: Tue, 9 Jan 2024 11:08:46 -0800 Message-ID: References: <83le8yps3s.fsf@gnu.org> <8334v6pc68.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1772"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jared@finder.org, 68334@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 09 20:09:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNHTU-0000Dq-S2 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jan 2024 20:09:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNHT7-0000oL-L2; Tue, 09 Jan 2024 14:08:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNHT5-0000mL-Vd for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 14:08:55 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNHT5-0004y6-N8 for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 14:08:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNHTC-0000G1-7Y for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 14:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jan 2024 19:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68334 X-GNU-PR-Package: emacs Original-Received: via spool by 68334-submit@debbugs.gnu.org id=B68334.1704827341983 (code B ref 68334); Tue, 09 Jan 2024 19:09:02 +0000 Original-Received: (at 68334) by debbugs.gnu.org; 9 Jan 2024 19:09:01 +0000 Original-Received: from localhost ([127.0.0.1]:40962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNHTB-0000Fm-0V for submit@debbugs.gnu.org; Tue, 09 Jan 2024 14:09:01 -0500 Original-Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:42460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNHT9-0000FX-6H for 68334@debbugs.gnu.org; Tue, 09 Jan 2024 14:08:59 -0500 Original-Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-557c188f313so3667867a12.1 for <68334@debbugs.gnu.org>; Tue, 09 Jan 2024 11:08:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704827326; x=1705432126; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=dr/pqXshlbTjqHPnAL1ZuXPMRoueA5Im7/qZoblY0Wc=; b=aJeb+pFPzv9CjXqk7ZiFd9VbQPH0ftg6hV9GTj7ZwaCUvktFCKS5zqh/2ORNb82FR1 LfPNQVeRhiBR01BpqaACvN7piivqungwWZkTjA31HbYBC2QWM35/vV2kWBNGaZhgOkYA 76UReguq5fCLIL3wZk/hjg7wfXzM/hV3P+gUwtRqB+eTn5Rtjwxb5EFK88JcqcayL8Xe F2xI7E7SSihezsvaLy0X9/y3eFBAl79SWs1DFb8zA6+qz+tgFLkXhlxEX9pbwSSY7UE3 0DYP4qKFouBnMcBsCW0htsr1a3yQfnAdIlZaFaCBF33anV21yfXcBRljQXt/qv3uInI5 XDNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704827326; x=1705432126; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dr/pqXshlbTjqHPnAL1ZuXPMRoueA5Im7/qZoblY0Wc=; b=cLHl5fgMcDyb2k3PuQ33OB3Xx0eAhCORvEmU2JJroa5/V+RmxDulWxWmf2iMVdmIYv 9nXkAXL37xEtDKKgQFXa5XBteO7HbfZ0iD4VOURziaDhwLqXjbji0YCQn0CuR6a/GAGN 0PO9GEhY9RrVIec8kH4vr6y1+q8ULA4mJWthf5CR7/Goh2BF7TpI4uAaowJv2WidEx6Q CM1+NWrf+7LDAI33bF/D+q1O6DvVHS1sETprPPk3C+YkdJoSCx9eWBIf/OsE6IawIFmU ehTe6261q8eys7h9ZcU8GBWp4K8SzgmRu/5qgRd9p17Rksoz/MBxbPq7M7WcGExWaFg2 68Jg== X-Gm-Message-State: AOJu0YwdgILWOlJWHwlO+dD8USC/Gglu/osBP4ERlm7nB4tw2iyABVl0 K3vYszhzs+I8SG0bXkRC8tmKX9AODr8Mr9GxNE+V09rY X-Google-Smtp-Source: AGHT+IHIxF0atzJKyo5QmnUL4vYF/7Rse/RhgbYCpzRgQ7Hm/85Dtwg2Qbt1RmPRHJKfD/YDHQHn3i9TV9CSGWCcJ9k= X-Received: by 2002:a50:bae7:0:b0:557:fc7a:3a5c with SMTP id x94-20020a50bae7000000b00557fc7a3a5cmr1200659ede.6.1704827326321; Tue, 09 Jan 2024 11:08:46 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 9 Jan 2024 11:08:46 -0800 In-Reply-To: <8334v6pc68.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277647 Archived-At: Eli Zaretskii writes: >> I didn't intend to propose including the existing implementation as is, >> which I hadn't looked closely at. Having done that just now, it seems >> like it's implemented on the tab bar, as Juri has pointed out. I think >> this is probably not the right thing for a feature in Emacs itself. > > How else do you expect this to be implemented on TTY frames? It can > either overwrite parts of the menu bar, or it could overwrite parts of > the tab bar. Something's gotta give, no? > > I also don't understand why the tab bar is deemed more important than > the tool bar. Let's let users decide what they prefer. (Of course, > if there's a way to let them have the cake and eat it, too, that would > be the best.) > >> This feature would be most useful as a first class feature, but that >> might require C changes. > > IMO, usurping one more screen line from TTY frames could be > problematic, especially on terminals that display a relatively small > number of lines. You could add another line, so that you could use the tab-bar and the tool-bar at the same time. That would provide the most flexibility for users, I think. They would themselves get to decide how many lines to sacrifice. (Many users also have huge screens these days, including vertical ones.) That said, I don't at all object to the current implementation as an optional feature in core, if you think it's a good idea. There's no reason to allow perfect to be the enemy of the good.