unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jared Finder <jared@finder.org>
Cc: 68334-done@debbugs.gnu.org
Subject: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals
Date: Thu, 11 Jan 2024 12:51:06 +0200	[thread overview]
Message-ID: <83v880kusl.fsf@gnu.org> (raw)
In-Reply-To: <8721504db5c2be47352db0230248f036@finder.org> (message from Jared Finder on Wed, 10 Jan 2024 14:59:25 -0800)

> Date: Wed, 10 Jan 2024 14:59:25 -0800
> From: Jared Finder <jared@finder.org>
> Cc: 68334@debbugs.gnu.org
> 
> > I don't see any problems with the change, but please add comments
> > there explaining that some parts of the code are supposed to work on
> > frames where images cannot be displayed, because it is very easy to
> > mistakenly assume this only needs to work on GUI frames.
> 
> New patch attached with comment added.

Thanks, installed on master.

> For the other discussions about making per-window tool bars part of 
> core, I expect a handful of additional patches so I can file a separate 
> bug report if that makes tracking things easier.

OK, so I'm closing this bug.





      reply	other threads:[~2024-01-11 10:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-08 21:39 bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-08 23:04 ` bug#68334: window-tool-bar (bug#68334) Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-09 13:06   ` Eli Zaretskii
2024-01-09  4:57 ` bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals Stefan Kangas
2024-01-09  7:58   ` Juri Linkov
2024-01-09 13:13   ` Eli Zaretskii
2024-01-09 18:39     ` Stefan Kangas
2024-01-09 18:57       ` Eli Zaretskii
2024-01-09 19:08         ` Stefan Kangas
2024-01-09 19:28           ` Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-09 19:56             ` Eli Zaretskii
2024-01-10  7:24             ` Juri Linkov
2024-01-09 12:40 ` Eli Zaretskii
2024-01-10 22:59   ` Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-11 10:51     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83v880kusl.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=68334-done@debbugs.gnu.org \
    --cc=jared@finder.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).