From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#62823: 29.0.60; Fixing a small leak in tree-sitter search functions Date: Tue, 5 Sep 2023 16:55:36 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6838"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62823-done@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 06 01:56:07 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdftv-0001bB-8P for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Sep 2023 01:56:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdftq-0001EB-IN; Tue, 05 Sep 2023 19:56:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdftp-0001Df-Fi for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 19:56:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdftp-0004so-56 for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 19:56:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdftp-0005aH-SB for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 19:56:01 -0400 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Sep 2023 23:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 62823 X-GNU-PR-Package: emacs Mail-Followup-To: 62823@debbugs.gnu.org, stefankangas@gmail.com, casouri@gmail.com Original-Received: via spool by 62823-done@debbugs.gnu.org id=D62823.169395814521437 (code D ref 62823); Tue, 05 Sep 2023 23:56:01 +0000 Original-Received: (at 62823-done) by debbugs.gnu.org; 5 Sep 2023 23:55:45 +0000 Original-Received: from localhost ([127.0.0.1]:59911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdftZ-0005Zh-31 for submit@debbugs.gnu.org; Tue, 05 Sep 2023 19:55:45 -0400 Original-Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]:42246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdftX-0005ZS-8h for 62823-done@debbugs.gnu.org; Tue, 05 Sep 2023 19:55:43 -0400 Original-Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-500bbe3ef0eso459259e87.1 for <62823-done@debbugs.gnu.org>; Tue, 05 Sep 2023 16:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693958136; x=1694562936; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=MmwVnIuKCzCC62Fv9iRnYUPkIgB5uNkdopjMrGgN9fM=; b=hqZsSSxsJCZMBiJ9vDYwavpFxBqHVtdG9bVrrCgX1qPoTUy9tN1T+21m78ZxxeMWkm DJkeeaUrwJpNuICyUEuSyMBpgdF6IuUJ/VanPzfaSnL397kw1DGk2TjNNOhh7hEtjlvJ dM9GrIaLQMdD1UV051M2Vgrs3G+fMrfshE9Z2xUIWIM34LFlnavQpq90IFMGN269RXli 8RB+hqXpkre9QnZRyGKoq0398RDoJ5pCXqqwlVa1YsUtN/0iHmpuilQKvv9smJ8vj/kf efa9nKv9D7vmvzKDUcFvDSPTwZ35RbrWGzmN/vSpBEZE45F3DhQtUjoCElRtp3ducYY2 2Xqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693958136; x=1694562936; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MmwVnIuKCzCC62Fv9iRnYUPkIgB5uNkdopjMrGgN9fM=; b=GcqTwyB/KS4sSf83LAFYsFj76lJs9e5F0jL02I5Mg+XrsjRkIzM929/1U1SIdx1UsO 8wWeKoO+uLPN1p92akN8oBu4QdNK8EWbW/3Ut3s9iAXKoorkEE0OKbxIIhlmjwH1KuuW 87GGpaRUXgZgVDA2ObbT+JAxr8ua82+aimDxCaKC7Fs2ky0RP9Ed/a9/601CNbCUs5r9 gYOx2QGR9EUyZBM26t1AKwj+QaYDCyqlbGdRlJFLNLzHiazXPLw/n/vuY+bCMFgsSIag 1QKaAbqQyQtBoWTzhOzHukC9cY1LRaKtsGFZekgQOMFK0eMJW8UmT5NXPOj+yjAQYm9W tqyg== X-Gm-Message-State: AOJu0YwC9HNa6I+GpGUnUfjC3My/RJzw0jRV/081cgUEYmVy24Vd6ew1 Qt+AbNNTTNUcltrdy56HPa8G5p/FH9ZvWgH6ibM= X-Google-Smtp-Source: AGHT+IELf1Y2irLcmtOiqUvhGrxbN4u0PUgIwtTrWNjtByrVyOGvucsYg2RNAWy0tO67ReOR+lpRBewmZjqmROxN+7M= X-Received: by 2002:a05:6512:e97:b0:4fe:28cd:b3f with SMTP id bi23-20020a0565120e9700b004fe28cd0b3fmr439251lfb.5.1693958136371; Tue, 05 Sep 2023 16:55:36 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 5 Sep 2023 16:55:36 -0700 In-Reply-To: (Yuan Fu's message of "Thu, 13 Apr 2023 15:48:43 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269445 Archived-At: Yuan Fu writes: > When we switch to using cursors instead of nodes [1] in treesit.c for > search functions, we introduced a small leak: the search functions > allows the user to pass a predicate function, which can signal. And > because we are now using cursors, which needs to be freed, everytime the > predicate function signals, the cursor is leaked. > > I pushed a fix to master (a5eb9f6ad4e), the change is relatively > straightforward so I hope we can pick it into the next pretest. > > And sorry for introducing the leak in the first place :-( It seems like this was already installed, so I'm closing this.