unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: David Fussner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Pip Cet <pipcet@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 41645@debbugs.gnu.org
Subject: bug#41645: 27.0.91; Combining Grapheme Joiner (#x34f) gui artifacts
Date: Fri, 5 Jun 2020 16:54:14 +0100	[thread overview]
Message-ID: <CADF+RtiG+Lr=Bjyzb1fxLOzsnpmSnGTjGeCM7+horoOaFRy=Xw@mail.gmail.com> (raw)
In-Reply-To: <87img53odf.fsf@gmail.com>

It looks fine on master here -- many thanks to you both. Should the
bug be closed?

On Fri, 5 Jun 2020 at 09:31, Pip Cet <pipcet@gmail.com> wrote:
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Pip Cet <pipcet@gmail.com>
> >> Cc: dfussner@googlemail.com,  41645@debbugs.gnu.org
> >> Date: Thu, 04 Jun 2020 22:48:19 +0000
> >>
> >> > The IT_CHARACTER case also does this when the pixel width comes out as
> >> > zero:
> >> >
> >> >          it->phys_ascent = it->ascent;
> >> >          it->phys_descent = it->descent;
> >>
> >> > That is, it doesn't trust the ascent/descent values from metrics.
> >> > Should we do the same for compositions, or did you see any reasons to
> >> > believe the metrics in this case?
> >>
> >> The former, I believe. I still think fonts with such glyphs are broken,
> >> and we should rely as little as possible on what they say about them.
> >>
> >> So I've done that in this new version.
> >
> > Thanks.  Please push to the master branch, with one nit:
> >
> >> +  if (glyph_not_available_p)
> >> +    {
> >> +      s->font_not_found_p = true;
> >> +    }
> >
> > Our style convention is not to use braces when the block entails only
> > one line.
>
> Thanks! I'd changed that code and missed that.





  reply	other threads:[~2020-06-05 15:54 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01 13:45 bug#41645: 27.0.91; Combining Grapheme Joiner (#x34f) gui artifacts David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-01 15:29 ` Eli Zaretskii
2020-06-01 15:50   ` Pip Cet
2020-06-01 16:06     ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-01 16:36       ` Eli Zaretskii
2020-06-01 17:44         ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-01 18:27       ` Pip Cet
2020-06-01 16:14     ` Eli Zaretskii
2020-06-01 18:09       ` Pip Cet
2020-06-01 18:37         ` Eli Zaretskii
2020-06-01 19:35           ` Eli Zaretskii
2020-06-01 20:15             ` Pip Cet
2020-06-01 19:48           ` Pip Cet
2020-06-01 22:37             ` Pip Cet
2020-06-02 13:45               ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-02 13:57                 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-02 14:06                   ` Pip Cet
2020-06-02 14:32                     ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-02 14:35                 ` Pip Cet
2020-06-02 14:39                   ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-02 15:51                 ` Eli Zaretskii
2020-06-02 15:59                   ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-02 16:07             ` Eli Zaretskii
2020-06-02 19:21               ` Pip Cet
2020-06-02 19:49                 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-03 14:20                 ` Eli Zaretskii
2020-06-03 14:58                   ` Pip Cet
2020-06-03 15:58                     ` Eli Zaretskii
2020-06-03 20:23                       ` Pip Cet
2020-06-04  2:36                         ` Eli Zaretskii
2020-06-04  6:58                           ` Pip Cet
2020-06-04 13:31                             ` Eli Zaretskii
     [not found]                               ` <874krq4fd8.fsf@gmail.com>
2020-06-05  7:45                                 ` Eli Zaretskii
2020-06-05  8:31                                   ` Pip Cet
2020-06-05 15:54                                     ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2020-06-05 17:28                                       ` Eli Zaretskii
2020-06-02 15:52         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADF+RtiG+Lr=Bjyzb1fxLOzsnpmSnGTjGeCM7+horoOaFRy=Xw@mail.gmail.com' \
    --to=bug-gnu-emacs@gnu.org \
    --cc=41645@debbugs.gnu.org \
    --cc=dfussner@googlemail.com \
    --cc=eliz@gnu.org \
    --cc=pipcet@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).