From: Pip Cet <pipcet@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: dfussner@googlemail.com, 41645@debbugs.gnu.org
Subject: bug#41645: 27.0.91; Combining Grapheme Joiner (#x34f) gui artifacts
Date: Wed, 03 Jun 2020 20:23:47 +0000 [thread overview]
Message-ID: <87v9k76gq4.fsf@gmail.com> (raw)
In-Reply-To: <834krscfa3.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 03 Jun 2020 18:58:28 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Pip Cet <pipcet@gmail.com>
>> Cc: dfussner@googlemail.com, 41645@debbugs.gnu.org
>> Date: Wed, 03 Jun 2020 14:58:07 +0000
>>
>> > I'm not sure I follow. What do you mean by "reject"? I thought the
>> > code which ignores the metric and sets the font_not_found_p flag when
>> > we get a zero-width glyph is a kind of "rejection".
>>
>> I mean "treat the glyph as non-existent". Currently, for (3), glyphs
>> with lbearing but no pixel width are treated as valid and expanded to
>> cover a single pixel, which is all but invisible on my screen.
>
> They are hard to spot, but if one looks close enough, IME they are
> visible.
>
> We could perhaps introduce a feature whereby such thin-space glyphs
> are somehow made to stand out more, but that would be a separate
> feature, because right now we have these 1-pixel thin spaces with many
> control characters.
Yes, you're right.
>
>> > If you disable auto-composition-mode, and use the
>> > fonts which shows CGJ as zero-width glyph, do you still see display
>> > artifacts?
>>
>> No.
>
> Then I think your suggestion to handle such lgstrings as we do with
> simple characters is sufficient to fix situations such as this one.
Okay. How's this patch?
From 1b8683cb24ba364475c864f708da7b32319fdd2e Mon Sep 17 00:00:00 2001
From: Pip Cet <pipcet@gmail.com>
Date: Wed, 3 Jun 2020 20:10:51 +0000
Subject: [PATCH] Avoid zero-width glyphs and the resulting cursor artifacts.
* src/xdisp.c (gui_produce_glyphs): Widen zero-width compositions to
one pixel. (Bug#41645)
---
src/xdisp.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/src/xdisp.c b/src/xdisp.c
index 0f06a38d40..414dc8809b 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -30592,6 +30592,12 @@ gui_produce_glyphs (struct it *it)
it->glyph_row->contains_overlapping_glyphs_p = true;
it->pixel_width = cmp->pixel_width;
+ if (it->pixel_width == 0)
+ {
+ /* We assure that all visible glyphs have at least 1-pixel
+ width. */
+ it->pixel_width = 1;
+ }
it->ascent = it->phys_ascent = cmp->ascent;
it->descent = it->phys_descent = cmp->descent;
IT_APPLY_FACE_BOX(it, face);
@@ -30623,6 +30629,12 @@ gui_produce_glyphs (struct it *it)
it->pixel_width
= composition_gstring_width (gstring, it->cmp_it.from, it->cmp_it.to,
&metrics);
+ if (it->pixel_width == 0)
+ {
+ /* We assure that all visible glyphs have at least 1-pixel
+ width. */
+ it->pixel_width = 1;
+ }
if (it->glyph_row
&& (metrics.lbearing < 0 || metrics.rbearing > metrics.width))
it->glyph_row->contains_overlapping_glyphs_p = true;
--
2.27.0.rc0
>> > If not, what do you see and why is this kind of
>> > 'rejection" not enough?
>>
>> CGJ is displayed as a black box as wide as a space, which is perfectly
>> fine. It's U+301 that's not.
>
> Hmm... how does U+301 enter this picture? What problems do you see
> with its display?
It's a single pixel in width and leaves the accent slightly off-center
as a result. Nothing major.
next prev parent reply other threads:[~2020-06-03 20:23 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 13:45 bug#41645: 27.0.91; Combining Grapheme Joiner (#x34f) gui artifacts David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-01 15:29 ` Eli Zaretskii
2020-06-01 15:50 ` Pip Cet
2020-06-01 16:06 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-01 16:36 ` Eli Zaretskii
2020-06-01 17:44 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-01 18:27 ` Pip Cet
2020-06-01 16:14 ` Eli Zaretskii
2020-06-01 18:09 ` Pip Cet
2020-06-01 18:37 ` Eli Zaretskii
2020-06-01 19:35 ` Eli Zaretskii
2020-06-01 20:15 ` Pip Cet
2020-06-01 19:48 ` Pip Cet
2020-06-01 22:37 ` Pip Cet
2020-06-02 13:45 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-02 13:57 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-02 14:06 ` Pip Cet
2020-06-02 14:32 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-02 14:35 ` Pip Cet
2020-06-02 14:39 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-02 15:51 ` Eli Zaretskii
2020-06-02 15:59 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-02 16:07 ` Eli Zaretskii
2020-06-02 19:21 ` Pip Cet
2020-06-02 19:49 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-03 14:20 ` Eli Zaretskii
2020-06-03 14:58 ` Pip Cet
2020-06-03 15:58 ` Eli Zaretskii
2020-06-03 20:23 ` Pip Cet [this message]
2020-06-04 2:36 ` Eli Zaretskii
2020-06-04 6:58 ` Pip Cet
2020-06-04 13:31 ` Eli Zaretskii
[not found] ` <874krq4fd8.fsf@gmail.com>
2020-06-05 7:45 ` Eli Zaretskii
2020-06-05 8:31 ` Pip Cet
2020-06-05 15:54 ` David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-05 17:28 ` Eli Zaretskii
2020-06-02 15:52 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9k76gq4.fsf@gmail.com \
--to=pipcet@gmail.com \
--cc=41645@debbugs.gnu.org \
--cc=dfussner@googlemail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).